Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We often come up against a similar issue where we don't know exactly the right permissions that github will need to deploy our infra changes because when we test locally we use our admin credentials which will always just work.
This pr adds a make command that can run terraform plans and applies but assumes the github role to do so. This means we will easily be able to find, re-create and debug errors locally rather than waiting till after the code is merged and fixing forward.
We do also need to extend the trust policy for the two github roles to allow devs to assume them which I have also done here.
NOTE: The change to the bootstrap policy can only be applied using our admin credentials since we do not want to allow that role to update itself. I have tried this in dev with the exact tf in this branch and it works fine. We just need to do the same change in each env.
Context
No more confusion around required deployment permissions.
The hope is that we can avoid the constant "oh no it needs this extra permission lets do a quick follow up pr to fix it" scenario.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.