Skip to content

Bugfix/eja fix targets and access #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eddalmond1 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfix/eja fix targets and access #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f60b84c
bugfix for access
eddalmond1 Dec 18, 2025
96f64f9
adding dev to make commands
eddalmond1 Dec 22, 2025
8d8ec8d
Merge branch 'main' into bugfix/eja-fix-targets-and-access
eddalmond1 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,13 @@ set-ratelimit: guard-APIM_ENV
< specification/x-nhsd-apim/ratelimit-template.yaml > specification/x-nhsd-apim/ratelimit.yaml

update-spec-template: guard-APIM_ENV
ifeq ($(APIM_ENV), $(filter $(APIM_ENV), sandbox internal-dev test int ref preprod prod ))
ifeq ($(APIM_ENV), $(filter $(APIM_ENV), sandbox internal-dev test int ref preprod prod dev ))
@ $(MAKE) set-target APIM_ENV=$$APIM_ENV
@ $(MAKE) set-access APIM_ENV=$$APIM_ENV
@ $(MAKE) set-security APIM_ENV=$$APIM_ENV
@ $(MAKE) set-ratelimit APIM_ENV=$$APIM_ENV
else
@ echo ERROR: $$APIM_ENV is not a valid environment. Please use one of [sandbox, internal-dev, int, ref, preprod, prod]
@ echo ERROR: $$APIM_ENV is not a valid environment. Please use one of [dev, sandbox, internal-dev, test, int, ref, preprod, prod]
@ exit 1;
endif

Expand Down
4 changes: 4 additions & 0 deletions specification/components/security/security-internal-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
nhs-login-p9:
$ref: https://proxygen.prod.api.platform.nhs.uk/components/securitySchemes/nhs-login-p9
app-level3:
$ref: https://proxygen.prod.api.platform.nhs.uk/components/securitySchemes/app-level3
6 changes: 6 additions & 0 deletions specification/x-nhsd-apim/access-internal-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- title: Eligibility Signposting API (Dev Environment)
grants:
nhs-login-p9: []
- title: Eligibility Signposting API (Dev Environment) app Level 3 Access
grants:
app-level3: []
2 changes: 2 additions & 0 deletions specification/x-nhsd-apim/access-preprod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
- title: Eligibility Signposting API (Pre Production Environment)
grants:
nhs-login-p9: []
- title: Eligibility Signposting API (Pre Production Environment) app Level 3 Access
grants:
app-level3: []
0 specification/x-nhsd-apim/ratelimit-dev.yaml → ...n/x-nhsd-apim/ratelimit-internal-dev.yaml
View file
Open in desktop
File renamed without changes.
0 specification/x-nhsd-apim/target-dev.yaml → ...tion/x-nhsd-apim/target-internal-dev.yaml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion specification/x-nhsd-apim/target-preprod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
type: external
url: "preprod.eligibility-signposting-api.nhs.uk"
url: "https://preprod.eligibility-signposting-api.nhs.uk"
healthcheck: /patient-check/_status
security:
type: mtls
Expand Down
2 changes: 1 addition & 1 deletion specification/x-nhsd-apim/target-prod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
type: external
url: "prod.eligibility-signposting-api.national.nhs.uk"
url: "https://prod.eligibility-signposting-api.national.nhs.uk"
healthcheck: /patient-check/_status
security:
type: mtls
Expand Down
2 changes: 1 addition & 1 deletion specification/x-nhsd-apim/target-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
type: external
url: "test.eligibility-signposting-api.nhs.uk"
url: "https://test.eligibility-signposting-api.nhs.uk"
healthcheck: /patient-check/_status
security:
type: mtls
Expand Down
Loading