Skip to content

NRL-2199 Add D2A type belonging to new non-SNOMED system#1210

Merged
katebobyn-nhs merged 9 commits intodevelopfrom
feature/kabo5-NRL-2199-hospital-discharge-pointer-type
Apr 30, 2026
Merged

NRL-2199 Add D2A type belonging to new non-SNOMED system#1210
katebobyn-nhs merged 9 commits intodevelopfrom
feature/kabo5-NRL-2199-hospital-discharge-pointer-type

Conversation

@katebobyn-nhs
Copy link
Copy Markdown
Contributor

@katebobyn-nhs katebobyn-nhs commented Apr 28, 2026

No description provided.

@katebobyn-nhs katebobyn-nhs requested a review from a team as a code owner April 28, 2026 08:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

💥 Something went wrong while building the pull request environment.
Check Output Logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

💥 Something went wrong while building the pull request environment.
Check Output Logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

💥 Something went wrong while building the pull request environment.
Check Output Logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

💥 Something went wrong while building the pull request environment.
Check Output Logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

🚀 PR environment successfully deployed.
Commit Hash: ff57532561eeedfa72a7f257ca5b864aedf05afa
URL: https://nrl2199-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

🚀 PR environment successfully deployed.
Commit Hash: 4f573d3070466a3fa3d7a81ad8fd230b6610b85f
URL: https://nrl2199-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

🚀 PR environment successfully deployed.
Commit Hash: fbc58719e99f55fb73ba72f293d643e03bd79f4b
URL: https://nrl2199-01ba47.api.record-locator.dev.national.nhs.uk/

anjalitrace2-nhs
anjalitrace2-nhs reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@anjalitrace2-nhs anjalitrace2-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look sensible 👍 just a couple questions

Comment thread resources/fhir/NRLF-RecordType-ValueSet.json
Comment thread layer/nrlf/core/validators.py
anjalitrace2-nhs
anjalitrace2-nhs approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@anjalitrace2-nhs anjalitrace2-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info, looks good to me!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

🚀 PR environment successfully deployed.
Commit Hash: 72347b5d761896a020a97c102ae23ecfeab20575
URL: https://nrl2199-01ba47.api.record-locator.dev.national.nhs.uk/

@katebobyn-nhs katebobyn-nhs merged commit 2a304c4 into develop Apr 30, 2026
11 checks passed
@katebobyn-nhs katebobyn-nhs deleted the feature/kabo5-NRL-2199-hospital-discharge-pointer-type branch April 30, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjalitrace2-nhs anjalitrace2-nhs anjalitrace2-nhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@katebobyn-nhs @anjalitrace2-nhs