Skip to content

NRL-2180 Make backup lifecycle duration fit into vault lock retention period range#1209

Merged
anjalitrace2-nhs merged 4 commits intodevelopfrom
NRL-2180-enable-compliance-mode-backups
Apr 28, 2026
Merged

NRL-2180 Make backup lifecycle duration fit into vault lock retention period range#1209
anjalitrace2-nhs merged 4 commits intodevelopfrom
NRL-2180-enable-compliance-mode-backups

Conversation

@anjalitrace2-nhs
Copy link
Copy Markdown
Contributor

@anjalitrace2-nhs anjalitrace2-nhs commented Apr 23, 2026

Questions to chat through:

  • do we want some backups to be kept for 400 days for realsies? yes
  • now that we can delete the whole lock policy if needed, shall we keep "backup:PutBackupVaultAccessPolicy"? yes - keep in line with blueprint
  • Can we enable compliance mode in the test account to give this a go from this branch? yes, and change it back within our grace period 30 days

✅ Create a lock in every account (TEST + PROD) but only enable compliance mode on the PROD one.
✅ Update min/max acceptable retention periods per environment.
✅ Keep the default changable_for_days to avoid accidentally enabling compliance mode by forgetting to provide an env-specific value.

@github-actions
Copy link
Copy Markdown

🚀 PR environment successfully deployed.
Commit Hash: f20ab1e739c39f2c420a704319009e0e892b631b
URL: https://nrl2180-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link
Copy Markdown

🚀 PR environment successfully deployed.
Commit Hash: 0de360400a4b64d24d59f1d9ce4c2a4bd1407fe9
URL: https://nrl2180-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link
Copy Markdown

🚀 PR environment successfully deployed.
Commit Hash: 35efd5c36c6a06deee006c60bcec30744df08823
URL: https://nrl2180-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link
Copy Markdown

🚀 PR environment successfully deployed.
Commit Hash: 35efd5c36c6a06deee006c60bcec30744df08823
URL: https://nrl2180-01ba47.api.record-locator.dev.national.nhs.uk/

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

🚀 PR environment successfully deployed.
Commit Hash: eae2b38447a229aaf1876372ae2d13a0eedc89ee
URL: https://nrl2180-01ba47.api.record-locator.dev.national.nhs.uk/

@anjalitrace2-nhs anjalitrace2-nhs merged commit f72e0a0 into develop Apr 28, 2026
11 checks passed
@anjalitrace2-nhs anjalitrace2-nhs deleted the NRL-2180-enable-compliance-mode-backups branch April 28, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants