Skip to content

Conversation

@valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Sep 17, 2025

Description

Latest draft PDF: https://github.com/NCAS-CMS/pyfive/blob/joss_paper/paper.pdf

Summary

This is the PR that contains the JOSS paper we are writing; this is DNM (do not merge) since we don't want to have the paper in our code base, but it makes it easier to contribute to the paper via code review, and it shows the JOSS folks that we are writing the paper off an up to date main branch, that is tested and has coverage measured.

How to work on it

  • checkout this joss_paper branch as per normal, make changes, commit and push
  • at push, the PDF compiler Github Action will run, that will produce the paper PDF and commit it to this branch, as well as create a paper.zip Artifact that can be downloaded (that only contains the paper pdf)
  • the latest draft PDF can be viewed here https://github.com/NCAS-CMS/pyfive/blob/joss_paper/paper.pdf
  • the latest draft paper.zip artifact is available on the Action page, eg https://github.com/NCAS-CMS/pyfive/actions/runs/17856845646
  • IMPORTANT since the bot pushes the latest draft here, you will always need to pull the latest branch locally ie do git pull origin joss_paper since you need to bring your HEAD to the latest state; if you don't, and get stuck at git conflicts, allow for merge with no rebase ie run git config pull.rebase false then pull again

Closes #94

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • [ ] Unit tests have been added (if codecov test fails)
  • [ ] Any changed dependencies have been added or removed correctly (if need be)
  • [ ] If you are working on the documentation, please ensure the current build passes
  • All tests pass

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.58%. Comparing base (85ba6aa) to head (dbc24f2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   72.58%   72.58%           
=======================================
  Files          11       11           
  Lines        2499     2499           
  Branches      379      379           
=======================================
  Hits         1814     1814           
  Misses        583      583           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valeriupredoi valeriupredoi marked this pull request as draft September 17, 2025 14:44
@valeriupredoi
Copy link
Collaborator Author

@bnlawrence had a very good point about running the JOSS converter on a draft, so I asked the JOSS folks at openjournals/joss#1456

@valeriupredoi

This comment was marked as outdated.

@valeriupredoi

This comment was marked as outdated.

@valeriupredoi
Copy link
Collaborator Author

@bnlawrence had a very good point about running the JOSS converter on a draft, so I asked the JOSS folks at openjournals/joss#1456

proves out there are multiple ways, described in the JOSS docs https://joss.readthedocs.io/en/latest/paper.html#checking-that-your-paper-compiles (duh!) - and the GHA one is perfect for us here, I'll implement it tomorrow 🥳

@valeriupredoi
Copy link
Collaborator Author

@bnlawrence this branch is now fully up to date with main; I am looking at the paper now, not reading it (since I read it last week), just looking to see if all the bits are in place etc. When do you want to submit?

@valeriupredoi valeriupredoi marked this pull request as ready for review December 15, 2025 12:43
@valeriupredoi
Copy link
Collaborator Author

valeriupredoi commented Dec 15, 2025

So I'm pasting the submission criteria here, taken from https://joss.readthedocs.io/en/latest/submitting.html:

  • Make your software available in an open repository (GitHub, Bitbucket, etc.) and include an OSI approved open source license.
  • Make sure that the software complies with the JOSS review criteria. In particular, your software should be full-featured, well-documented, and contain procedures (such as automated tests) for checking correctness.
  • Write a short paper in Markdown format using paper.md as file name, including a title, summary, author names, affiliations, and key references. See our example paper to follow the correct format.
  • (Optional) create a metadata file describing your software and include it in your repository. We provide a script that automates the generation of this metadata.

@bnlawrence the short submission form is here and needs a login, if you'd like to do that perfect, if not I can create a new account for meself 🍺

@bnlawrence
Copy link
Collaborator

I have submitted this to JOSS. I guess when the review is done we kill this as a pull request, but keep the branch.

@valeriupredoi
Copy link
Collaborator Author

I have submitted this to JOSS. I guess when the review is done we kill this as a pull request, but keep the branch.

legend, cheers, Bryan! I should guess the review and changes from it will happen in a fork of this at JOSS? Yes, we should update the files with the final versions, after review, then I'll close the PR without merge but will deffo keep the branch, and I'll protect it from deletion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paper submission to JOSS

7 participants