-
Notifications
You must be signed in to change notification settings - Fork 24
[DNM][JOSS] JOSS paper #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 72.58% 72.58%
=======================================
Files 11 11
Lines 2499 2499
Branches 379 379
=======================================
Hits 1814 1814
Misses 583 583
Partials 102 102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bnlawrence had a very good point about running the JOSS converter on a draft, so I asked the JOSS folks at openjournals/joss#1456 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
proves out there are multiple ways, described in the JOSS docs https://joss.readthedocs.io/en/latest/paper.html#checking-that-your-paper-compiles (duh!) - and the GHA one is perfect for us here, I'll implement it tomorrow 🥳 |
|
@bnlawrence this branch is now fully up to date with |
|
So I'm pasting the submission criteria here, taken from https://joss.readthedocs.io/en/latest/submitting.html:
@bnlawrence the short submission form is here and needs a login, if you'd like to do that perfect, if not I can create a new account for meself 🍺 |
|
I have submitted this to JOSS. I guess when the review is done we kill this as a pull request, but keep the branch. |
legend, cheers, Bryan! I should guess the review and changes from it will happen in a fork of this at JOSS? Yes, we should update the files with the final versions, after review, then I'll close the PR without merge but will deffo keep the branch, and I'll protect it from deletion |
Description
Latest draft PDF: https://github.com/NCAS-CMS/pyfive/blob/joss_paper/paper.pdf
Summary
This is the PR that contains the JOSS paper we are writing; this is DNM (do not merge) since we don't want to have the paper in our code base, but it makes it easier to contribute to the paper via code review, and it shows the JOSS folks that we are writing the paper off an up to date
mainbranch, that is tested and has coverage measured.How to work on it
joss_paperbranch as per normal, make changes, commit and pushpaper.zipArtifact that can be downloaded (that only contains the paper pdf)paper.zipartifact is available on the Action page, eg https://github.com/NCAS-CMS/pyfive/actions/runs/17856845646git pull origin joss_papersince you need to bring your HEAD to the latest state; if you don't, and get stuck at git conflicts, allow for merge with no rebase ie rungit config pull.rebase falsethen pull againCloses #94
Before you get started
Checklist
[ ] Unit tests have been added (if codecov test fails)[ ] Any changed dependencies have been added or removed correctly (if need be)[ ] If you are working on the documentation, please ensure the current build passes