Skip to content

reduce max threads to 30#336

Open
valeriupredoi wants to merge 2 commits into
mainfrom
reduce_maxthreads_2
Open

reduce max threads to 30#336
valeriupredoi wants to merge 2 commits into
mainfrom
reduce_maxthreads_2

Conversation

@valeriupredoi
Copy link
Copy Markdown
Collaborator

@valeriupredoi valeriupredoi commented May 28, 2026

Description

Investigations in #335 show that we don't really take a performance hit from lowering the number of max threads used by Active, but we manage to coax the CEDA NGINX server to complete its work without issues (most of the times).

EDIT: it appears that test outcmes are pretty bad today - and, as @varsiha-sothilingam mentioned, we are going to wait to see the new CEDA NGINX storage performance via here.

Contributes towards avoiding #329
Closes #333 and #335

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@valeriupredoi valeriupredoi added the enhancement New feature or request label May 28, 2026
@varsiha-sothilingam
Copy link
Copy Markdown

I would be interested to wait until the new ESGF-NG configurations from the JASMIN team are in place as it may be the case we can keep a high MAX_THREAD count. This could be important for high concurrency down the line for multiple users requesting reductions. I can run a simple MAX_THREAD v Run Time test to understand for https server so we can see what is optimal, rather than just patching with 30 at the moment. Thoughts/ opinions welcome

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (cb5b5c9) to head (4bb439f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files           7        7           
  Lines         685      685           
=======================================
  Hits          638      638           
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valeriupredoi
Copy link
Copy Markdown
Collaborator Author

I would be interested to wait until the new ESGF-NG configurations from the JASMIN team are in place as it may be the case we can keep a high MAX_THREAD count. This could be important for high concurrency down the line for multiple users requesting reductions. I can run a simple MAX_THREAD v Run Time test to understand for https server so we can see what is optimal, rather than just patching with 30 at the moment. Thoughts/ opinions welcome

indeed what I thought too! We can do tests via here 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants