Fix offline tool when relative path is supplied #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peverwhee
requested review from
climbfuji,
dustinswales,
gold2718,
grantfirl and
mkavulich
as code owners
climbfuji
approved these changes
Dec 15, 2025
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Tiny pull requests get quick reviews. This looks good, thanks for fixing and for adding the test for the tool.
dustinswales
approved these changes
Dec 16, 2025
Member
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
Thanks for adding a test for the metadata comparison script!
gold2718
approved these changes
Dec 18, 2025
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
This looks okay although I think the shell script can be shortened a bit.
| ## Relevant directories and file paths | ||
| root_dir="$(cd $(dirname ${0}); pwd -P)" | ||
| script_dir="$(dirname ${root_dir})/scripts/fortran_tools" | ||
| test_root_dir="$(dirname ${root_dir})/test" |
Collaborator
There was a problem hiding this comment.
Isn't test_root_dir the same as root_dir?
Collaborator
Author
There was a problem hiding this comment.
good point! removed!
climbfuji
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fix to allow the offline metadata parser to work with a relative path. Also includes a new test for the offline tool.
User interface changes?: No
fixes #709