Route model_mod calls for DART programs though assim_model_mod#1069
Open
hkershaw-brown wants to merge 1 commit intomainfrom
Open
Route model_mod calls for DART programs though assim_model_mod#1069hkershaw-brown wants to merge 1 commit intomainfrom
hkershaw-brown wants to merge 1 commit intomainfrom
Conversation
hkershaw-brown
force-pushed
the
though_assim_model
branch
from
74b72f6 to
141330d
Compare
Member
Author
hkershaw-brown
force-pushed
the
though_assim_model
branch
from
141330d to
0eba96d
Compare
mjs2369
approved these changes
Apr 15, 2026
Contributor
mjs2369
left a comment
mjs2369
left a comment
There was a problem hiding this comment.
Hi @hkershaw-brown , this looks great. I wasn't able to find any issues in the code changes, and I think we can be sure we got all the files that were going through model_mod
hkershaw-brown
added
release!
Public model_mod routines through assim_mod_mod model_mod_check use assim_mod_mod::interpolate FIXMES fixed: * nc_write_model_atts - was not going though assim_model_mod * read_model_time in direct_netcdf_mod was not going though assim_model_mod Left alone model specific programs, i.e. those in models directory and the two obs converters that use model info: * create_identity_stream_flow_obs (models/wrf_hydro) * convert_roms_obs (obs_converters/ROMS) fixes #1056
hkershaw-brown
force-pushed
the
though_assim_model
branch
from
0eba96d to
7ec0791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request routes model_mod calls for DART programs though assim_model_mod.
model_mod_check was partially using assim_model_mod, and partially directly calling model_mod which
did not allow you to create a custom intercept layer using assim_model_mod (e.g having multiple model_mods).
Changes: call assim_model_mod rather than model_mod directly for dart programs
FIXMES fixed:
Left alone model specific programs, i.e. those in models directory and the two obs converters that use model info:
This is because the model specific code is making assumptions about the state, e.g. the identity obs, state indexing.
And I think programs in the models/MODEL directory are assuming they are not using the intercept layer.
Fixes issue
fixes #1056
Types of changes
I'm putting bug fix since there are FIXMEs about this
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
run_all_quickdbuild.sh
For searching for occurrences:
ripgrep -i -e 'use\s*model_mod\s*,\s*only'ripgrep -i -e 'use\s*model_mod\s*,\s*only' --glob '!models/*'Note obs_timejitter.f90 is one of the programs that is never routinely compiled #1068, I will add quickdbuild.sh to exercise these program builds.
Checklist for merging
Checklist for release
Testing Datasets