Skip to content

Fix spherical to Cartesian conversion in State.from_ephem#452

Open
mkelley wants to merge 2 commits into
NASA-Planetary-Science:mainfrom
mkelley:bugfix-state-from_ephem-202605
Open

Fix spherical to Cartesian conversion in State.from_ephem#452
mkelley wants to merge 2 commits into
NASA-Planetary-Science:mainfrom
mkelley:bugfix-state-from_ephem-202605

Conversation

@mkelley
Copy link
Copy Markdown
Member

@mkelley mkelley commented May 19, 2026

Fixes #450 .

@github-actions
Copy link
Copy Markdown

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.11%. Comparing base (e720e46) to head (17e9e3d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files          53       53           
  Lines        4339     4339           
=======================================
  Hits         3563     3563           
  Misses        776      776           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkelley mkelley requested a review from hhsieh00 May 19, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discrepancy in State objects depending on how JPL Horizons is queried

1 participant