Skip to content

Remove python3.5 references #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephanMeijer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove python3.5 references #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
language: python
python: "3.5.2"
python: "3.12"
before_install:
install: make install-requirements
script: make test
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
PY=python3.5
PY=python3
files=nbp/**/*.py
module=nbp

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ interface is provided for running experiments.

## How to run from source

For running the simulator, Python `3.5.x` or higher is required.
For running the simulator, Python `3.8` or higher is required.

Not tested on `Mac OS X`/`macOS` or `Microsoft Windows`.

Expand Down
4 changes: 2 additions & 2 deletions tests/integration_tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from nbp import Cli

def test_required_arguments(capsys):
argv = "python3.5 nbp_cli.py".split(" ")
argv = "python3 nbp_cli.py".split(" ")

with pytest.raises(SystemExit):
Cli(argv).start_application()
Expand All @@ -18,7 +18,7 @@ def test_required_arguments(capsys):
assert "--outputwriter/-o" in err

def test_forbid_max_ticks_with_max_time(capsys):
argv = "python3.5 nbp_cli.py -i json -o json -dt 1 --max-ticks 1 --max-time 1".split(" ")
argv = "python3 nbp_cli.py -i json -o json -dt 1 --max-ticks 1 --max-time 1".split(" ")

with pytest.raises(SystemExit):
Cli(argv).start_application()
Expand Down
18 changes: 9 additions & 9 deletions tests/integration_tests/test_greater_than.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,62 +27,62 @@ def greater_than_zero_should_pass(capsys, command, parameter):
def test_delta_time_greater_than_zero(capsys):
greater_than_zero(
capsys,
"python3.5 nbp_cli.py -i json -o json -dt 0",
"python3 nbp_cli.py -i json -o json -dt 0",
"--delta-time/-dt"
)

def test_max_ticks_greater_than_zero(capsys):
greater_than_zero(
capsys,
"python3.5 nbp_cli.py -i json -o json -dt 1 --max-ticks 0",
"python3 nbp_cli.py -i json -o json -dt 1 --max-ticks 0",
"--max-ticks/-t"
)

def test_max_time_greater_than_zero(capsys):
greater_than_zero(
capsys,
"python3.5 nbp_cli.py -i json -o json -dt 1 --max-time 0",
"python3 nbp_cli.py -i json -o json -dt 1 --max-time 0",
"--max-time/-T"
)

def test_delta_time_not_negative(capsys):
greater_than_zero(
capsys,
"python3.5 nbp_cli.py -i json -o json -dt -1",
"python3 nbp_cli.py -i json -o json -dt -1",
"--delta-time/-dt"
)

def test_max_ticks_not_negative(capsys):
greater_than_zero(
capsys,
"python3.5 nbp_cli.py -i json -o json -dt 1 --max-ticks -1",
"python3 nbp_cli.py -i json -o json -dt 1 --max-ticks -1",
"--max-ticks/-t"
)

def test_max_time_not_negative(capsys):
greater_than_zero(
capsys,
"python3.5 nbp_cli.py -i json -o json -dt 1 --max-time -1",
"python3 nbp_cli.py -i json -o json -dt 1 --max-time -1",
"--max-time/-T"
)

def test_delta_time_positive(capsys):
greater_than_zero_should_pass(
capsys,
"python3.5 nbp_cli.py -i json -o json -dt 1",
"python3 nbp_cli.py -i json -o json -dt 1",
"--delta-time/-dt"
)

def test_max_ticks_positive(capsys):
greater_than_zero_should_pass(
capsys,
"python3.5 nbp_cli.py -i json -o json -dt 1 --max-ticks 1",
"python3 nbp_cli.py -i json -o json -dt 1 --max-ticks 1",
"--max-ticks/-t"
)

def test_max_time_positive(capsys):
greater_than_zero_should_pass(
capsys,
"python3.5 nbp_cli.py -i json -o json -dt 1 --max-time 1",
"python3 nbp_cli.py -i json -o json -dt 1 --max-time 1",
"--max-time/-T"
)