improve the build script #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements for the database build fix :
First off nice work! you managed to fix the build script with minimal changes. I added some improvements for the work done by :
python3and notpythonwhich is the standard on lots of *nix machines especially Debian basedsort -S 100%causing the script to exit silently due to the os killing it for consuming lots of resources, changed it to 80% ( tho in my case when i built the database locally i used-S 4Gfor the sort commands )combine_grouped_links_file.pywas loading the whole text files in a dictionary in memory, i changed that by streaming the text and sorting from the two text files instead, this helps a lot for RAM consumption ( the build process is still fast )prune_pages_file.py, i removed it and corrected the condition ( i generated the database with and without this fix to test and the pages table had a little less rows after correcting the condition )