Add output_path option to assembly_plan_RDF_to_JSON and update build compiler#31
Merged
Gonza10V merged 1 commit intoJan 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
output.json.Description
output_path: str | Path | Noneparameter toassembly_plan_RDF_to_JSONand write JSON to the provided path, defaulting tooutput.jsonwhen omitted (src/buildcompiler/robotutils.py).assembly_compilerto callassembly_plan_RDF_to_JSON(..., output_path=f"{files_path}/assemblyplan_output.json")so the zip step uses the generated file (src/buildcompiler/buildcompiler.py).isinstance(file, sbol2.Document)in both robotutils modules and tidy up a now-unused import/assignment in the build compiler.Testing
pytest, which executed the test suite but produced network-related failures/errors against external services (proxy blocked access to synbiohub.org / validator.sbolstandard.org), so several tests failed or errored; this is due to external network validation calls, not the JSON output change.ruff check src, which passed with no remaining lint errors.Codex Task