This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Add bitcoin protocol handler for PWA
#896
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes MutinyWallet#547 In my testing I could only make the `bitcoin` handler work. This is likely due to the ["safelisted schemes"](https://html.spec.whatwg.org/multipage/system-state.html#safelisted-scheme). The `send?invoice=%s` url was already being handled by the `parsePaste` function but the invoice data wasn't getting picked up, so I had to add the `handleDestination` call in there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #547
In my testing I could only make the
bitcoinhandler work. This is likely due to the "safelisted schemes".The
send?invoice=%surl was already being handled by theparsePastefunction but the invoice data wasn't getting picked up, so I had to add thehandleDestinationcall in there.