This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Fix BDK needing resync #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyRonning
approved these changes
Aug 8, 2023
Contributor
AnthonyRonning
left a comment
AnthonyRonning
left a comment
There was a problem hiding this comment.
good find, yeah that makes sense.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally found the reason why we would always need to resync bdk. We were removing the bdk keychain from memory after reading so we didnt overload memory, however, we needed this because we read the current bdk keychain and merge with the update, if we remove it from our in memory cache, then we have nothing to merge with.
This should let us bring back #690