Skip to content

Fix world folder being lowercased due to namespace changes in 26.1 #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benwoo1110 merged 1 commit into from
Apr 8, 2026
+3 −1
Merged

Fix world folder being lowercased due to namespace changes in 26.1 #3440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/org/mvplugins/multiverse/core/world/helpers/WorldNameChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,16 @@
if (worldName == null) {
return FolderStatus.DOES_NOT_EXIST;
}
File worldFolder = BukkitCompatibility.getWorldFoldersDirectory().resolve(worldName).toFile();

if (BukkitCompatibility.isUsingNewDimensionStorage()) {
File oldWorldFolder = Bukkit.getWorldContainer().toPath().resolve(worldName).toFile();
if (checkFolder(oldWorldFolder) == FolderStatus.VALID) {
return FolderStatus.REQUIRES_MIGRATION;
}
worldName = worldName.toLowerCase(Locale.ENGLISH); // namespace is case-insensitive and stored as lowercase

Check warning on line 129 in src/main/java/org/mvplugins/multiverse/core/world/helpers/WorldNameChecker.java

View workflow job for this annotation

GitHub Actions / checkstyle / checkstyle 

[checkstyle] reported by reviewdog 🐶
Don't use trailing comments.

Raw Output:
/github/workspace/src/main/java/org/mvplugins/multiverse/core/world/helpers/WorldNameChecker.java:129:64: warning: Don't use trailing comments. (com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck)

Check warning on line 129 in src/main/java/org/mvplugins/multiverse/core/world/helpers/WorldNameChecker.java

View workflow job for this annotation

GitHub Actions / checkstyle / checkstyle 

[checkstyle] reported by reviewdog 🐶
Assignment of parameter 'worldName' is not allowed.

Raw Output:
/github/workspace/src/main/java/org/mvplugins/multiverse/core/world/helpers/WorldNameChecker.java:129:23: warning: Assignment of parameter 'worldName' is not allowed. (com.puppycrawl.tools.checkstyle.checks.coding.ParameterAssignmentCheck)
}

File worldFolder = BukkitCompatibility.getWorldFoldersDirectory().resolve(worldName).toFile();
return checkFolder(worldFolder);
}

Expand Down
Loading