fix: Remove \r from js template strings #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be required for the string to match runtime. This is similar to how we handle verbatim strings in c#
There was a problem hiding this comment.
Pull Request Overview
This PR removes carriage return characters from JavaScript template strings to ensure runtime string consistency, aligning its handling with C# verbatim strings.
- Updated L10nParser.cs to remove "\r" from strings with a backtick (`) container.
- Added a test in ParserTests.cs verifying that a JS template string with "\r\n" is correctly normalized to "\n".
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MN.L10n/L10nParser.cs | Added handling for removing "\r" from JS template strings. |
| MN.L10n.Tests/ParserTests.cs | Added a test verifying the proper handling of newline normalization in JS template strings. |
Files not reviewed (2)
- MN.L10n.BuildTasks/MN.L10n.BuildTasks.csproj: Language not supported
- MN.L10n/MN.L10n.csproj: Language not supported
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where JavaScript template strings inadvertently include carriage return characters. The changes include:
- Removing "\r" characters from phrases when the string container is a backtick.
- Adding a unit test to verify the behavior of JS template strings.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MN.L10n/L10nParser.cs | Added handling for JS template strings by stripping "\r". |
| MN.L10n.Tests/ParserTests.cs | Added a new test to verify correct newline behavior. |
Files not reviewed (2)
- MN.L10n.BuildTasks/MN.L10n.BuildTasks.csproj: Language not supported
- MN.L10n/MN.L10n.csproj: Language not supported
Comments suppressed due to low confidence (1)
MN.L10n.Tests/ParserTests.cs:173
- [nitpick] Consider adding a test case with a JS template string that contains a carriage return (\r) without a newline (\n) to ensure all scenarios are covered.
var src = "_s(`Hello\r\nbrother!`)";
LinusCenterstrom
changed the title
LinusCenterstrom
changed the title
itssimple
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be required for the string to match runtime.
This is similar to how we handle verbatim strings in c#