Fixed issues with escaped strings inside the phrase #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had issues with phrases that looks like this "Byt artikel" listar artiklar direkt since the quotes will be escaped in the source. But the backslash escaping the quote should not be a part of the phrase to translate in and of itself. This is very similar to the issue with newlines we fixed here #176 I could add more cases (for instance \t) but this is the only one I know we actually use
itssimple
approved these changes
Mar 21, 2025
…n to get the correct dependency
This fixes a bug where the first character in the string is an escaped stringcontainer char
Collaborator
Author
|
The initial implementation didn't work when the first character was an escaped quote for some reason. We changed the implementation to instead post-process the result which seems simpler |
itssimple
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had issues with phrases that looks like this
since the quotes will be escaped in the source. But the backslash escaping the quote should not be a part of the phrase to translate in and of itself. This is very similar to the issue with newlines we fixed here #176
I could add more cases (for instance \t) but this is the only one I know we actually use