modifying picard/hsmetrics.py add target coverage#3285
Open
carmelinacharalambous wants to merge 2 commits intoMultiQC:mainfrom
Open
modifying picard/hsmetrics.py add target coverage#3285carmelinacharalambous wants to merge 2 commits intoMultiQC:mainfrom
carmelinacharalambous wants to merge 2 commits intoMultiQC:mainfrom
Conversation
| plot=linegraph.plot(gc_data[anchor], pconfig), | ||
| ) | ||
| return len(all_sample_data) | ||
|
|
There was a problem hiding this comment.
Bug: Duplicate Function Definition and Incorrect Usage
The _parse_target_coverage function is defined twice (lines 438 and 498), causing the first definition to be overwritten and unreachable. It's also defined with self but called with module (line 227), and attempts to use self.add_section(), which will fail since it's a standalone function. This appears to be accidentally committed development code.
Author
|
@vladsavelyev Hi Vlad, can I please receive help regarding this PR to hopefully pass the checks and push it to next release please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These plots provide valuable insights into hybrid-capture efficiency and library quality.
--strictflag)