Skip to content

GH-5758 and NOISSUE Fixes comments in VersionFilterData.h and fixes Java 25 requirement in VerifyJavaInstall.cpp #5759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
potato98765 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

GH-5758 and NOISSUE Fixes comments in VersionFilterData.h and fixes Java 25 requirement in VerifyJavaInstall.cpp #5759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ab1344
Update VersionFilterData.h
potato98765 May 3, 2026
32a6e93
Fix Java 25 requirement
potato98765 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions launcher/minecraft/VersionFilterData.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ struct VersionFilterData
QDateTime java17BeginsDate;
// Release data of the first version to require java 21 (24w14a)
QDateTime java21BeginsDate;
// release date of first version to use --quickPlayMultiplayer instead of --server/--port for directly joining servers
QDateTime java25BeginsDate;
// release date of first version to require java 25 (26.1 Snapshot 1) and new "year.drop.hotfix" version format
QDateTime java25BeginsDate;
// release date of first version to use --quickPlayMultiplayer instead of --server/--port for directly joining servers
QDateTime quickPlayBeginsDate;
// release date of last version to support LiteLoader (1.12.2)
QDateTime liteLoaderEndsDate;
Expand Down
2 changes: 1 addition & 1 deletion launcher/minecraft/launch/VerifyJavaInstall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void VerifyJavaInstall::executeTask() {

// Java 25 Requirement
if (minecraftComponent->getReleaseDateTime() >= g_VersionFilterData.java25BeginsDate) {
if (javaVersion.major() < 21) {
if (javaVersion.major() < 25) {
emit logLine("Minecraft 26.1 Snapshot 1 and above require the use of Java 25",
MessageLevel::Fatal);
emitFailed(tr("Minecraft 26.1 Snapshot 1 and above require the use of Java 25"));
Expand Down