Conversation
|
Hi @sophiemiddleton,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. ⌛ The following tests have been triggered for 2610df8: build (Build queue - API unavailable) |
|
this is an initial draft with most of the work. I have a small issues to fix before it becomes a full PR |
|
☀️ The build tests passed at 2610df8.
N.B. These results were obtained from a build of this Pull Request at 2610df8 after being merged into the base branch at 6a994e7. For more information, please check the job page here. |
| Disk(VEC3 const& norm,VEC3 const& udir, VEC3 const& center, double radius) | ||
| */ | ||
| Calo::Calo() : | ||
| EMC_Disk_0_Inner_ { std::make_shared<Cylinder>(VEC3(0.0,0.0,1.0),VEC3(0.0,0.0,1667),335,192.295)}, |
There was a problem hiding this comment.
z position here is what seems to be incorrect - need to understand why
This pull request introduces support for calorimeter (Calo) surfaces in the geometry and extrapolation infrastructure, enabling track extrapolation to the calorimeter disks. The main changes include defining Calo surfaces, integrating them into surface mapping, and adding extrapolation logic to reach Calo disks. Additionally, configuration options are updated to allow extrapolation to Calo disks.
Calorimeter surface integration:
Caloclass to define the geometry of calorimeter disks and edges, including inner/outer cylinders and front/back disks for both disk 0 and disk 1 (KinKalGeom/inc/Calo.hh,KinKalGeom/src/Calo.cc). [1] [2]SurfaceMapclass and surface mapping logic, allowing retrieval and mapping of Calo surfaces (KinKalGeom/inc/SurfaceMap.hh,KinKalGeom/src/SurfaceMap.cc). [1] [2] [3]Extrapolation enhancements:
ExtrapolateCaloclass to handle extrapolation predicates and logic for reaching Calo disks, including methods for finding nearest disks and intersection checks (Mu2eKinKal/inc/ExtrapolateCalo.hh).KKExtrapclass to include extrapolation methods for Calo disks and associated member variables for Calo disk surfaces and predicates (Mu2eKinKal/inc/KKExtrap.hh). [1] [2] [3]Configuration updates:
ToCaloD0,ToCaloD1) in the FCL files to control extrapolation to Calo disks (Mu2eKinKal/fcl/prolog.fcl). [1] [2] [3]Surface ID and mapping updates:
SurfaceIdenumeration and mapping to include Calo disk surfaces, and updated string mappings for these IDs (DataProducts/inc/SurfaceId.hh,DataProducts/src/SurfaceId.cc). [1] [2]MakeSurfaceSteps_module.ccto map new Calo surface IDs and add debug output for Calo-related steps (CommonMC/src/MakeSurfaceSteps_module.cc). [1] [2]Build system update:
Calo.ccto the build system for compilation (KinKalGeom/CMakeLists.txt).