This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Created an Annotation for Registering Apps#131
Open
AlexCouch wants to merge 4 commits intoMrCrayfish:masterfrom
AlexCouch:registry
Open
Created an Annotation for Registering Apps#131AlexCouch wants to merge 4 commits intoMrCrayfish:masterfrom AlexCouch:registry
AlexCouch wants to merge 4 commits intoMrCrayfish:masterfrom
AlexCouch:registry
Conversation
… system, debug, or normal app through the use of the annotation.
|
Great idea! I hope this gets accepted |
Author
|
Well, cray has already made his own version while I was making this. But I'm currently finalizing a plugin system for adding support for different uses of an annotation |
…support for autoregistering things for device mod
|
Ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went ahead and created that annotation you were talking about. It was pretty simple tbh. I didn't have to changed anything in the original code, just had to provide a way for the app class to be pushed from the annotation backend to the actual registration system:
ApplicationManager#registerApplication. Created a simple wrapper interface that gets implemented when the class gets hooked through the annotation. The annotation's information gets passed into said interface,IAppContainer, as well as the class instance of the app class gets stored in the interface instance as well to be passed into the original registration system.