Feature: Add large slider popup#1457
Open
mrariden wants to merge 8 commits into
Open
Conversation
…SaturationSliderDialog
Collaborator
Author
Tests passing on
GUI manual testing:Image loading
Network
GUI: display
GUI: mouse/ROIs
GUI: menus
Filtering
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be helpful to have more range on the slider to get the viewer saturation just right. Added low/high textboxes as well. The textboxes and slider all validate user inputs.
The popup opens with right click and is attached to the slider that was right-clicked.
Rewired the signal passing between the sliders to make it more extensible for future changes with arbitrary channel colors.
Example screenshot:

TODO:
RTDNo references in RTD docs