Skip to content

Limit JSON payload and register token size#27

Open
juanfradb wants to merge 1 commit into
MostroP2P:mainfrom
juanfradb:fix/json-payload-size-limits
Open

Limit JSON payload and register token size#27
juanfradb wants to merge 1 commit into
MostroP2P:mainfrom
juanfradb:fix/json-payload-size-limits

Conversation

@juanfradb
Copy link
Copy Markdown
Contributor

Summary

  • add an explicit 8 KiB JsonConfig default for API JSON extractors
  • cap /api/register token values at 4096 bytes
  • keep /api/register body bounded at 128 KiB so oversized-token validation can return 400 while 1 MB payloads return 413
  • document request body and token limits in docs/api.md

Security validation

Source/sink/control: attacker-controlled JSON bodies and register token values reached Actix JSON extraction and token storage without explicit size controls. The app now configures bounded JSON extraction and rejects register tokens above 4096 bytes before storage.

Original issue no longer reproduces:

  • 1 MB JSON payload to /api/register returns 413
  • 100 KiB token in /api/register returns 400
  • non-register JSON body above the 8 KiB default returns 413

Refs #8

Tests

  • cargo test payload -- --nocapture
  • cargo test register_hundred_kb_token_returns_400 -- --nocapture
  • cargo test
  • cargo fmt --check
  • cargo clippy --all-targets -- -D warnings
  • git diff --check

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Warning

Rate limit exceeded

@juanfradb has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 32 minutes and 3 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4920018c-6ebe-402f-ad28-7586488b2cb5

📥 Commits

Reviewing files that changed from the base of the PR and between 893e7e1 and 5293500.

📒 Files selected for processing (4)
  • docs/api.md
  • src/api/routes.rs
  • src/api/test_support.rs
  • src/main.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AndreaDiazCorreia
Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Member

@AndreaDiazCorreia AndreaDiazCorreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job but Before merging: the 413 body comes back as text/plain and echoes the exact server limit (JSON payload (X bytes) is larger than allowed (limit: Y bytes)), which both breaks the JSON everywhere shape and gives free fingerprinting, so please add an error_handler on both JsonConfigs returning something like {"success":false,"message":"Payload too large"}. Also missing a test for the 413 path on /api/notify covering registered vs unregistered plus x-request-id presence, which matters given that endpoint's privacy contract. Optional nits: 128 KiB on /api/register is generous (16 to 32 KiB would do the same job with less parse surface), and JSON_PAYLOAD_LIMIT_BYTES could be renamed DEFAULT_JSON_PAYLOAD_LIMIT_BYTES for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants