Skip to content

fix(kosong): strip JSON Schema metadata from Google GenAI tool parameters #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaoju111a wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(kosong): strip JSON Schema metadata from Google GenAI tool parameters #739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/kosong/src/kosong/contrib/chat_provider/google_genai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,12 +354,21 @@ def tool_to_google_genai(tool: KosongTool) -> Tool:
"""Convert a Kosong tool to GoogleGenAI tool format."""
# Kosong already validates parameters as JSON Schema format via jsonschema
# The google-genai SDK accepts dict format and internally converts to Schema

# Strip JSON Schema metadata fields (google-genai SDK has extra='forbid')
# Note: $defs/definitions are already removed by kosong's deref_json_schema()
parameters = {
k: v
for k, v in tool.parameters.items()
if k not in ("$schema", "$id", "$comment", "examples")
}

return Tool(
function_declarations=[
FunctionDeclaration(
name=tool.name,
description=tool.description,
parameters=tool.parameters, # type: ignore[arg-type] # GoogleGenAI accepts dict
parameters=parameters, # type: ignore[arg-type] # GoogleGenAI accepts dict
)
]
)
Expand Down
Loading