fix(build): include lazy CLI subcommands in PyInstaller hiddenimports#1510
Open
hzeng1998 wants to merge 1 commit intoMoonshotAI:mainfrom
Open
fix(build): include lazy CLI subcommands in PyInstaller hiddenimports#1510hzeng1998 wants to merge 1 commit intoMoonshotAI:mainfrom
hzeng1998 wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes PyInstaller-packaged binary runtime failures by ensuring modules for lazy-loaded CLI subcommands are included as hiddenimports, keeping packaging in sync with the lazy-subcommand registry.
Changes:
- Derive PyInstaller
hiddenimportsfor lazy CLI subcommands fromLazySubcommandGroup.lazy_subcommands. - Extend the hiddenimports snapshot test to include the lazy CLI subcommand modules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/kimi_cli/utils/pyinstaller.py |
Adds lazy CLI subcommand modules to PyInstaller hiddenimports, derived from the lazy-subcommand registry. |
tests/utils/test_pyinstaller_utils.py |
Updates snapshot to assert lazy CLI subcommand modules are present in hiddenimports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes packaged-binary runtime failures for lazy-loaded CLI subcommands.
After lazy-loading of CLI subcommands was introduced in
82425a0c, PyInstaller no longer collected those dynamically imported modules automatically.As a result, bundled binaries could fail with
ModuleNotFoundErrorwhen running subcommands likekimi weborkimi info.Changes
hiddenimports.LazySubcommandGroup.lazy_subcommandsso it stays in sync automatically.test_pyinstaller_hiddenimportssnapshot to cover the lazy CLI modules.Affected Commands (packaged binary)
kimi infokimi exportkimi mcpkimi viskimi webVerification
uv run pytest tests/utils/test_pyinstaller_utils.py -k hiddenimports -vvuv run pyinstaller kimi.specdist/kimi web --helpdist/kimi info --helpImpact