fix(web): stabilize WebSocket connect to prevent reconnection storms#1419
Open
howardpen9 wants to merge 1 commit intoMoonshotAI:mainfrom
Open
fix(web): stabilize WebSocket connect to prevent reconnection storms#1419howardpen9 wants to merge 1 commit intoMoonshotAI:mainfrom
howardpen9 wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
…n storms The `connect` callback had many unstable dependencies (handleMessage, onError, sendInitialize, etc.) that frequently changed identity due to their own deep dependency chains. When connect changed, it cascaded to reconnect → sendMessage → queue auto-send effects, potentially causing rapid connect/close/reconnect cycles. This extends the ref-based pattern from MoonshotAI#1386 to all callbacks used inside connect(). By reading from refs (handleMessageRef, onErrorRef, etc.) instead of capturing callbacks directly, connect() only depends on sessionId and stable state setters, breaking the cascade. Closes MoonshotAI#1409
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1409 — web mode keeps refreshing with rapid WebSocket connect/close cycles (visible as incrementing client ports in terminal logs).
Root cause: The
connectcallback captured multiple frequently-changing callbacks (handleMessage,onError,sendInitialize, etc.) as direct dependencies. When any of these changed identity — often triggered by deep dependency chains throughprocessEvent—connectwas recreated, which cascaded toreconnect→sendMessage→ queue auto-send effects, triggering new connections that closed the previous one.Fix: Extends the ref-based stabilization pattern from #1386 to all callbacks used inside
connect(). By reading from refs (handleMessageRef,onErrorRef,sendInitializeRef, etc.) instead of capturing callbacks directly,connect()only depends onsessionIdand stable state setters — breaking the identity cascade entirely.Changes
handleMessage,onError,sendInitialize,sendPendingMessage,getWebSocketUrl,completeStreamingMessagesconnect,disconnect,cancel,reconnect, andsendMessageto use refs instead of direct callback referencessessionId,setMessages,setAwaitingFirstResponse)Test plan
kimi web, open browser — verify no rapid WebSocket reconnection cycle in terminal logs