Reduce allocations by reusing the String that holds the cell value#6
Merged
MonterraByte merged 1 commit intomasterfrom Mar 13, 2025
Merged
Reduce allocations by reusing the String that holds the cell value#6MonterraByte merged 1 commit intomasterfrom
MonterraByte merged 1 commit intomasterfrom
Conversation
Currently, the code allocates twice for every cell of the table. This commit changes it to allocate only once for the whole table (barring any reallocations necessary to grow the String), significantly reducing allocations (the only other place in the code that allocates is the BufWriter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the code allocates twice for every cell of the table. This commit changes it to allocate only once for the whole table (barring any reallocations necessary to grow the String), significantly reducing allocations (the only other place in the code that allocates is the BufWriter).