Fix from upstream MojoShader for NOT operator.#3
Open
tomspilman wants to merge 2 commits intomainfrom
Open
Conversation
tomspilman
commented
Jan 23, 2026
| const RegisterType regtype = ctx->source_args[0].regtype; | ||
| if ((regtype != REG_TYPE_PREDICATE) && (regtype != REG_TYPE_CONSTBOOL)) | ||
| fail(ctx, "IF src0 must be CONSTBOOL or PREDICATE"); | ||
| else if (!replicate_swizzle(ctx->source_args[0].swizzle)) |
Member
Author
There was a problem hiding this comment.
NOTE: This code was removed in the upstream MojoShader repo, but i cannot tell when or why.
But this change makes the test shader in...
Compile.
Member
Author
|
Ok this all works and the test shader in... ... compile now. I built all the stock effects and verified that these MojoShader changes do not break them. And in theory these changes at worst would cause shaders that didn't compile before, to compile. It should not break any working shaders. So i feel this is safe, but maybe needs a little testing by users on their own shaders to ensure no issues. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See icculus/mojoshader@fa633ad
Fixes MonoGame/MonoGame#8655.