-
Notifications
You must be signed in to change notification settings - Fork 5
Deprecation fixes to make the CI build #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Spindel
wants to merge
21
commits into
master
Choose a base branch
from
dep-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _lib is not accessible in more modern PyOpenSSL and thus won't need to be batched, better to not fail then.
This uses the most basic update to the model code to work in SqlAlchemy 2.0. The declarative attribuetes may need an overhaul anyhow.
This makes it explicit that we use UTC sans tzinfo, and thus avoid an warning from python 3.11+ datetime library. As the DB schema has no tzinfo, this makes it consistent.
because requests should have version=0
Because it helps to have it.
As of now, due to transient dependencies we cannot avoid deprecation warnings, and thus we should not make those be errors
This re-generates the test fixtures ( with an very ugly script) in order to set them up as-was but with valid certs that have the versions and such loadable.
This adds a two way generate & compare operation for the parts that generate our CA keys for the fixtures, in order to verify that we get bit-identical output where we want them.
Turns out that global variables can make things work that should not work
This sets it up to work without OpenSSL and moves the code that was duplicated from test fixture generation back home
This gets rid of the OpenSSL code and uses the recommended cryptography module instead. Some quirks of behaviour are still there, but I think ti mostly works out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the bare minimum maintainance to make it work with the current gen python libraries.