Skip to content

🐛 Bugfix: skill deletion failed occasionally #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jasonxia007 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

🐛 Bugfix: skill deletion failed occasionally #2772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7424348
🐛 Bugfix: skill deletion failed occasionally
Jasonxia007 Apr 9, 2026
ace2f8e
♻️ Simplify how run_skill_script() receives additional parameters
Jasonxia007 Apr 10, 2026
9aee4ce
🧪 Add test files
Jasonxia007 Apr 10, 2026
c0a2bde
🧪 Fix test files
Jasonxia007 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/database/skill_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,11 +352,12 @@ def delete_skill(skill_name: str, updated_by: Optional[str] = None) -> bool:
updated_by: User ID of the user performing the delete

Returns:
True if deleted successfully
True if deleted successfully, False if skill not found or already deleted
"""
with get_db_session() as session:
skill = session.query(SkillInfo).filter(
SkillInfo.skill_name == skill_name
SkillInfo.skill_name == skill_name,
SkillInfo.delete_flag != 'Y'
).first()

if not skill:
Expand Down
Loading
Loading