-
Notifications
You must be signed in to change notification settings - Fork 466
🔨 improve the CICD process. #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the CI/CD process by modifying GitHub Actions workflow triggers to work with pull requests instead of push events, and fixes conditional logic for determining when Docker builds should run.
- Removes push triggers on develop branch and switches to pull request-based file change detection
- Updates conditional logic to use
github.event.pull_request.files.*.filenameinstead ofgithub.event.head_commit - Adds debug logging to help troubleshoot pull request file detection
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/docker-build-dev.yml | Updates workflow triggers and conditional logic for PR-based builds with debug output |
| make/main/Dockerfile | Adds empty line at beginning of file |
| frontend/public/locales/en/common.json | Adds empty line after opening brace |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - name: Build web image (arm64) and load locally | ||
| run: | | ||
| docker buildx build --platform linux/arm64 -t nexent/nexent-web:dev-arm64 --load -f make/web/Dockerfile . | ||
| docker buildx build --platform linux/amd64 -t nexent/nexent-web:dev-amd64 --load -f make/web/Dockerfile . |
Copilot
AI
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job is named 'build-web-arm64' but the command builds for linux/amd64 platform and tags as dev-amd64. This appears to be a copy-paste error - it should build for linux/arm64 platform and tag as dev-arm64.
| docker buildx build --platform linux/amd64 -t nexent/nexent-web:dev-amd64 --load -f make/web/Dockerfile . | |
| docker buildx build --platform linux/arm64 -t nexent/nexent-web:dev-arm64 --load -f make/web/Dockerfile . |
| contains(github.event.pull_request.files.*.filename, 'backend/') || | ||
| contains(github.event.pull_request.files.*.filename, 'sdk/') || | ||
| contains(github.event.pull_request.files.*.filename, 'make/main/') |
Copilot
AI
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The github.event.pull_request.files array is not available by default in GitHub Actions. This property requires using the GitHub API or a third-party action to populate file information. The workflow will likely fail with these conditions.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔨 improve the CICD process.