Skip to content

Conversation

@jimfcarroll
Copy link
Contributor

This works for all of the mods I tried (about 10 of them). If they don't have a recognizable format that seems to be detected correctly also - therefore requiring a manual install.

Copy link
Contributor Author

@jimfcarroll jimfcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Holt59
Copy link
Member

Holt59 commented Nov 9, 2025

Looks good to me

https://github.com/ModOrganizer2/modorganizer-basic_games/actions/runs/19197881946/job/54881500872?pr=201

Either add checks for None if relevant, or add assert to disable the error if you know the entry are never None.

@jimfcarroll jimfcarroll force-pushed the master branch 2 times, most recently from 4f6d8a7 to 2086e7e Compare November 11, 2025 13:45
@jimfcarroll
Copy link
Contributor Author

Looks good to me

https://github.com/ModOrganizer2/modorganizer-basic_games/actions/runs/19197881946/job/54881500872?pr=201

Either add checks for None if relevant, or add assert to disable the error if you know the entry are never None.

Hey thanks. I fixed the errors and the linting passes now.

@Holt59 Holt59 merged commit d7e0c5a into ModOrganizer2:master Nov 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants