Skip to content

Entity Display Block entity models have no lighting #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Awakened-Redstone merged 2 commits into from
Apr 4, 2026
+3 −1
Merged

Entity Display Block entity models have no lighting #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c6468
Merge pull request #1 from ModFest/26.1
HyperPigeon Apr 1, 2026
b126602
- Fixed bug where entity models from entity display block had no ligh…
HyperPigeon Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/dev/hephaestus/glowcase/block/entity/EntityDisplayBlockEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ public void setDisplayEntity(Entity displayEntity) {

public static void tick(Level world, BlockPos blockPos, BlockState state, EntityDisplayBlockEntity blockEntity) {
if (blockEntity.displayEntity == null && blockEntity.entityType != null) {
blockEntity.setDisplayEntity(blockEntity.entityType.create(world, EntitySpawnReason.EVENT));
Entity displayEntity = blockEntity.entityType.create(world, EntitySpawnReason.EVENT);
displayEntity.snapTo(blockPos.getX(),blockPos.getY(),blockPos.getZ());
blockEntity.setDisplayEntity(displayEntity);
}
// if (blockEntity.getDisplayEntity() != null && blockEntity.getDisplayEntity().getType().is(TICK)) {
if (blockEntity.getDisplayEntity() != null && blockEntity.getDisplayEntity().getType().builtInRegistryHolder().is(TICK)) {
Expand Down
Loading