notice(non_ascii_or_non_printable_char): use standard fieldName#2165
Open
c-tonneslan wants to merge 1 commit into
Open
notice(non_ascii_or_non_printable_char): use standard fieldName#2165c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
The serialized output of this notice carries the offending column under the key 'columnName', but every other notice uses 'fieldName' (see InvalidCurrencyNotice, InvalidPhoneNumberNotice, etc.). Pipelines consuming the validator output have to special-case this one validator. Just match the convention. Callers already pass cellContext.fieldName() into the constructor, so no behavior changes - only the JSON key the field reflects to. Closes MobilityData#1205. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serialized output of
NonAsciiOrNonPrintableCharNoticecarries the offending column under the keycolumnName, but every other notice (InvalidCurrencyNotice,InvalidPhoneNumberNotice, etc.) usesfieldName. That forces downstream pipelines to special-case this one rule.Just renamed the field to match. Callers already pass
cellContext.fieldName()into the constructor positionally, so no caller signatures change and no behavior changes — only the JSON key the field reflects to.Closes #1205.