Skip to content

fix: tolerate missing cache metrics in Xcode logs #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FerAlquiciraInEtsy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: tolerate missing cache metrics in Xcode logs #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Sources/XCLogParser/activityparser/IDEActivityModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,10 +792,10 @@ public class IDEActivityLogSectionAttachment: Encodable {
} else {
let legacy = try decoder.decode(LegacyCacheMetrics.self, from: jsonData)
self.counters = [
"clangCacheHits": legacy.clangCacheHits,
"clangCacheMisses": legacy.clangCacheMisses,
"swiftCacheHits": legacy.swiftCacheHits,
"swiftCacheMisses": legacy.swiftCacheMisses,
"clangCacheHits": legacy.clangCacheHits ?? 0,
"clangCacheMisses": legacy.clangCacheMisses ?? 0,
"swiftCacheHits": legacy.swiftCacheHits ?? 0,
"swiftCacheMisses": legacy.swiftCacheMisses ?? 0,
]
self.taskCounters = [:]
}
Expand All @@ -805,8 +805,8 @@ public class IDEActivityLogSectionAttachment: Encodable {

/// Legacy Xcode 15.3 - Xcode 26.3 BuildOperationMetrics format, used only for deserialization.
private struct LegacyCacheMetrics: Decodable {
let clangCacheHits: Int
let clangCacheMisses: Int
let swiftCacheHits: Int
let swiftCacheMisses: Int
let clangCacheHits: Int?
let clangCacheMisses: Int?
let swiftCacheHits: Int?
let swiftCacheMisses: Int?
}