Skip to content

[feature] 구독 동아리 목록 페이지#1632

Open
seongwon030 wants to merge 4 commits into
feature/web-shell-migrationfrom
feature/#1623-add-subscribed-clubs-page-MOA-926
Open

[feature] 구독 동아리 목록 페이지#1632
seongwon030 wants to merge 4 commits into
feature/web-shell-migrationfrom
feature/#1623-add-subscribed-clubs-page-MOA-926

Conversation

@seongwon030
Copy link
Copy Markdown
Member

요약

바텀 네비 웹뷰 이관(MOA-923)의 구독 탭 구현. /webview/subscribed에서 구독한 동아리 목록을 보여준다.

변경

  • WebviewSubscribedPage — 구독한 동아리 목록 + 빈/로딩/에러 상태
  • useWebviewSubscribesubscribedClubIdsuseGetCardList 결과를 메모리 필터
  • ClubCard/SubscribeButton 재사용, 빈 상태에서 "동아리 보러 가기" → /webview/main
  • PAGE_VIEW.WEBVIEW_SUBSCRIBED_PAGE, PAGE_NAME.WEBVIEW_SUBSCRIBED 추가

의존성

검증

  • npm run typecheck, eslint 통과

Refs #1623

- WebviewBottomNav(홈/구독/메뉴) 신규, 상단 필터칩(동아리/홍보)과 별개 config
- WebviewLayout에 영구 바텀바 장착 + 콘텐츠 하단 패딩
- /webview/subscribed, /webview/menu 라우트 추가 (페이지는 placeholder, 후속 구현)
- 동아리 상세에서 바텀바 숨김, 홈 탭은 main/promotions에서 활성
- /webview/subscribed: 구독한 동아리 목록 + 빈/로딩/에러 상태
- useWebviewSubscribe + useGetCardList 메모리 필터로 구독 동아리만 표시
- ClubCard/SubscribeButton 재사용, 빈 상태에서 /webview/main 이동
- PAGE_VIEW.WEBVIEW_SUBSCRIBED_PAGE, PAGE_NAME.WEBVIEW_SUBSCRIBED 추가
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
moadong Ready Ready Preview, Comment Jun 1, 2026 2:25pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Warning

Review limit reached

@seongwon030, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 9 minutes and 57 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dcabb454-f2bd-488b-a774-5d424c9f6c90

📥 Commits

Reviewing files that changed from the base of the PR and between b7439f5 and d599f7a.

📒 Files selected for processing (10)
  • frontend/src/components/common/WebviewBottomNav/WebviewBottomNav.styles.ts
  • frontend/src/components/common/WebviewBottomNav/WebviewBottomNav.tsx
  • frontend/src/constants/eventName.ts
  • frontend/src/pages/WebviewLayout/WebviewLayout.styles.ts
  • frontend/src/pages/WebviewLayout/WebviewLayout.tsx
  • frontend/src/pages/WebviewMenuPage/WebviewMenuPage.tsx
  • frontend/src/pages/WebviewSubscribedPage/WebviewSubscribedPage.styles.ts
  • frontend/src/pages/WebviewSubscribedPage/WebviewSubscribedPage.tsx
  • frontend/src/routes/webviewBottomNavConfig.ts
  • frontend/src/routes/webviewRoutes.tsx

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/#1623-add-subscribed-clubs-page-MOA-926

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seongwon030 seongwon030 changed the title feat: 구독 동아리 목록 페이지 (#1623) [feature] 구독 동아리 목록 페이지 Jun 1, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new webview bottom navigation bar (WebviewBottomNav) with tabs for Home, Subscribed, and Menu, and integrates it into the WebviewLayout. It also adds the WebviewSubscribedPage to display subscribed clubs, along with a placeholder WebviewMenuPage and corresponding routing updates. The review feedback highlights an issue where the bottom padding on ContentArea is still applied even when the bottom navigation bar is hidden (such as on the club detail page), and suggests conditionally applying this padding using a $hideBottomNav prop.

Comment thread frontend/src/pages/WebviewLayout/WebviewLayout.tsx Outdated
Comment thread frontend/src/pages/WebviewLayout/WebviewLayout.styles.ts Outdated
- 동아리 상세에서 바텀바 숨김 + 하단 패딩 제거를 WebviewLayout에서 일괄 제어
- WebviewBottomNav 중복 경로 체크 제거, isActive 타입을 WebviewBottomNavPath로
- NavButton에 aria-current 추가, 스타일 theme를 ThemeProvider accessor로
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant