[feature] 구독 동아리 목록 페이지#1632
Conversation
- WebviewBottomNav(홈/구독/메뉴) 신규, 상단 필터칩(동아리/홍보)과 별개 config - WebviewLayout에 영구 바텀바 장착 + 콘텐츠 하단 패딩 - /webview/subscribed, /webview/menu 라우트 추가 (페이지는 placeholder, 후속 구현) - 동아리 상세에서 바텀바 숨김, 홈 탭은 main/promotions에서 활성
- /webview/subscribed: 구독한 동아리 목록 + 빈/로딩/에러 상태 - useWebviewSubscribe + useGetCardList 메모리 필터로 구독 동아리만 표시 - ClubCard/SubscribeButton 재사용, 빈 상태에서 /webview/main 이동 - PAGE_VIEW.WEBVIEW_SUBSCRIBED_PAGE, PAGE_NAME.WEBVIEW_SUBSCRIBED 추가
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 9 minutes and 57 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
Warning
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new webview bottom navigation bar (WebviewBottomNav) with tabs for Home, Subscribed, and Menu, and integrates it into the WebviewLayout. It also adds the WebviewSubscribedPage to display subscribed clubs, along with a placeholder WebviewMenuPage and corresponding routing updates. The review feedback highlights an issue where the bottom padding on ContentArea is still applied even when the bottom navigation bar is hidden (such as on the club detail page), and suggests conditionally applying this padding using a $hideBottomNav prop.
- 동아리 상세에서 바텀바 숨김 + 하단 패딩 제거를 WebviewLayout에서 일괄 제어 - WebviewBottomNav 중복 경로 체크 제거, isActive 타입을 WebviewBottomNavPath로 - NavButton에 aria-current 추가, 스타일 theme를 ThemeProvider accessor로
…ure/#1623-add-subscribed-clubs-page-MOA-926
요약
바텀 네비 웹뷰 이관(MOA-923)의 구독 탭 구현.
/webview/subscribed에서 구독한 동아리 목록을 보여준다.변경
WebviewSubscribedPage— 구독한 동아리 목록 + 빈/로딩/에러 상태useWebviewSubscribe의subscribedClubIds로useGetCardList결과를 메모리 필터ClubCard/SubscribeButton재사용, 빈 상태에서 "동아리 보러 가기" →/webview/mainPAGE_VIEW.WEBVIEW_SUBSCRIBED_PAGE,PAGE_NAME.WEBVIEW_SUBSCRIBED추가의존성
검증
npm run typecheck, eslint 통과Refs #1623