Open
Conversation
Adds a 500-line limit on Python files enforced via `make file_len_check` (included in `make ci`) and the linter GitHub Actions workflow. Files exceeding the limit can be added to [tool.file_length] exclude in pyproject.toml. Includes a Cursor rule documenting the rationale. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR adds a Python file-length CI check that enforces a 500-line maximum across the codebase, with a configurable exclude list in
Previous review concerns (cross-platform path matching via Confidence Score: 5/5
Important Files Changed
Reviews (2): Last reviewed commit: "🐛 address PR review feedback: cross-pla..." | Re-trigger Greptile |
- Use pathlib.Path instead of PurePosixPath in type annotation - Use rel.as_posix() for exclude matching to handle Windows paths Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make file_len_check) that enforces a 500-line maximum, preventing AI-generated code from becoming monolithic[tool.file_length]inpyproject.tomlwith an exclude list for justified exceptions (currentlyonboard.pyat 655 lines)make ciand the linter GitHub Actions workflow.cursor/rules/file_length.mdc) documenting the rationale and refactoring guidanceTest plan
make file_len_checkpasses withonboard.pyexcludedonboard.py(655 lines) would be caught without the exclusion🤖 Generated with Claude Code