Fix/perps share poster layout#6407
Open
SeniorZhai wants to merge 12 commits into
Open
Conversation
Swap horizontal/vertical padding on the side and leverage tags so the text is no longer cramped vertically, and nudge the trend image margin.
Use a single image that already includes the Mixin wordmark for both the market and perps share posters. The market layout switches via a new market_logo theme attribute so light/dark variants pick the right asset; the perps poster uses a white-on-gradient asset that doesn't need a night variant.
Perps closed share now prefers the order's roe so the PnL% matches the server value, falling back to the local close-ROE calculation when roe is empty. Market share switches the stable side from OMNI USDT to the Ethereum USDT so the resulting swap link is actually routable. Also shortens the zh "limit price" label.
Drop the local close-ROE fallback and use the order's roe value directly so the displayed PnL% matches the server number on every close.
Align Opened/Closed/Added Failed string keys with mixin-strings PR 421 and rename View_Market to view_perps_market.
Add USD amount (quantity * entry_price / leverage) to the right side of opened/added activity list rows and as a new row under entry price on the activity detail page. Also drop the share button from the activity detail header so only view market remains for opened and added orders.
Pick the available margin token with the largest balance for open and add position flows; fall back to the backend order when no token has a balance or balances tie.
Drop the separate fiat-symbol arg from market_cap/price strings and inline it at the call site. Replace market_share_card_market_button with the shared R.string.Market label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.