Fix/compilation warnings by SeniorZhai · Pull Request #6405 · MixinNetwork/android-app

SeniorZhai · 2026-05-25T07:08:20Z

No description provided.

- Replace deprecated RoomWarnings.CURSOR_MISMATCH with QUERY_MISMATCH - Add @RewriteQueriesToDropUnusedColumns to DAO interfaces - Fix SQL syntax error in Web3WalletDao subquery

- Replace deprecated ClickableText with Text and LinkAnnotation - Update hiltViewModel import to non-deprecated package - Add @param: target to @DrawableRes in AppDrawables

- Suppress DEPRECATION warnings for EncryptedSharedPreferences - Fix migration parameter naming in SignalDatabase - Remove redundant else branch in MixinIdentityKeyStore

- Remove unnecessary non-null assertion in TransactionResponse - Suppress deprecation for AssetsExtra in MixinDatabase - Update fallbackToDestructiveMigration call in PerpsDatabase - Add @IgnoredOnParcel to WalletItem - Add @param: target to @TypeConverters in Web3Transaction

…ant null checks

Copilot

Pull request overview

This PR focuses on reducing/clearing compilation warnings across the Android app module by adding targeted suppressions and tightening Kotlin/annotation usage (Parcelize, Room, Hilt, null-safety), plus a handful of small refactors.

Changes:

Added many file-level @file:Suppress(...) directives (primarily DEPRECATION / OVERRIDE_DEPRECATION) to silence deprecation-related warnings.
Updated Kotlin usages to remove redundant conversions / null-assertions, adjust annotation targets (@param:, @field:), and modernize Parcelize imports.
Minor refactors in a few areas (Compose text links, Room DAO warnings, network response handling, etc.).

Reviewed changes

Copilot reviewed 222 out of 222 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
app/src/main/java/one/mixin/android/widget/ViewfinderView.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/ToolView.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/theme/ThemeActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/ReplyView.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/QuoteView.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/PlayerBottomControlView.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/PercentView.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/linktext/GestureAutoLinkTextView.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/GestureMessageLayout.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/GestureFrameLayout.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/gallery/ui/GalleryActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/gallery/internal/model/SelectedItemCollection.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/DebugClickListener.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/ContentEditText.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/CoilRoundedHexagonTransformation.kt	Rename transform param to match API expectations
app/src/main/java/one/mixin/android/widget/BottomSheet.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/bot/BotDock.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/BlurTransformation.kt	Suppress deprecation warnings + rename transform param
app/src/main/java/one/mixin/android/widget/AvatarsView.kt	Remove redundant float conversion
app/src/main/java/one/mixin/android/widget/audio/BlinkingDrawable.kt	Suppress override deprecation warnings at file level
app/src/main/java/one/mixin/android/widget/AddressTextView.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/web3/swap/Components/RecentSwapTokens.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/web3/details/Web3TransactionsFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/web3/details/Web3TransactionFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/vo/TranscriptMessage.kt	Migrate to `kotlinx.parcelize.Parcelize`
app/src/main/java/one/mixin/android/vo/SnapshotItem.kt	Null-safety refactor in `isDataIncomplete()`
app/src/main/java/one/mixin/android/vo/route/serializer/SafeBoxSerializer.kt	Rename serializer arg + minor cleanup
app/src/main/java/one/mixin/android/vo/MixinInvoice.kt	Remove redundant `toString()` usage in comparisons/assignment
app/src/main/java/one/mixin/android/vo/ChatHistoryMessageItem.kt	Simplify null handling in `absolutePath()`
app/src/main/java/one/mixin/android/util/video/MixinPlayer.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/util/TextLoader.kt	Change response body usage (now requires proper closing)
app/src/main/java/one/mixin/android/util/mlkit/scan/utils/BitmapUtils.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/util/mlkit/scan/manager/BeepManager.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/util/mlkit/scan/camera/config/ResolutionCameraConfig.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/util/MemoryCallback.kt	Suppress override deprecation warnings at file level
app/src/main/java/one/mixin/android/util/database/DatabaseUtil.kt	Cursor close simplification
app/src/main/java/one/mixin/android/util/Base58.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/util/backup/Backup.kt	Remove redundant safe-calls after guaranteed initialization
app/src/main/java/one/mixin/android/ui/web/WebFragment.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/web/WebActivity.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/Web3TypeMenuData.kt	Use-site target resource annotations (`@param:`)
app/src/main/java/one/mixin/android/ui/wallet/Web3TokenFilterBottomSheetDialogFragment.kt	Remove redundant `else -> {}` in `when`
app/src/main/java/one/mixin/android/ui/wallet/Web3HiddenAssetsFragment.kt	Remove unreachable/null walletId handling (walletId is required)
app/src/main/java/one/mixin/android/ui/wallet/WalletSecurityActivity.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/WalletActivity.kt	Remove unreachable `else` in sealed `when`
app/src/main/java/one/mixin/android/ui/wallet/ViewWalletAddressFragment.kt	Remove unnecessary `!!` usage
app/src/main/java/one/mixin/android/ui/wallet/TransferContactBottomSheetDialogFragment.kt	Remove redundant `toString()` call
app/src/main/java/one/mixin/android/ui/wallet/transfer/widget/TransferErroContent.kt	Null-safety cleanup and string interpolation tightening
app/src/main/java/one/mixin/android/ui/wallet/transfer/TransferInvoiceBottomSheetDialogFragment.kt	Remove unnecessary `inline` on factory
app/src/main/java/one/mixin/android/ui/wallet/TransactionsFragment.kt	Null-safety refactor when reading withdrawal receiver
app/src/main/java/one/mixin/android/ui/wallet/SortMenuData.kt	Use-site target resource annotations (`@param:`)
app/src/main/java/one/mixin/android/ui/wallet/PinBiometricsBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/IdentityFragment.kt	Remove redundant `else` branches in sealed `when`
app/src/main/java/one/mixin/android/ui/wallet/fiatmoney/SelectCardBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/fiatmoney/OrderStatusFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/fiatmoney/OrderConfirmFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/fiatmoney/FiatMoneyViewModel.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/fiatmoney/CalculateFragment.kt	Remove redundant invalid-number toast branch (flow change)
app/src/main/java/one/mixin/android/ui/wallet/DepositShareActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/DepositQrBottomFragment.kt	Tighten Observable generic type
app/src/main/java/one/mixin/android/ui/wallet/components/InTransitionDuration.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/components/ImportWalletDetailPage.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/AddFeeBottomSheetDialogFragment.kt	Use `getParcelableCompat` + remove redundant null elvis for symbols
app/src/main/java/one/mixin/android/ui/wallet/adapter/SnapshotAdapter.kt	Remove redundant null fallbacks for header id/time
app/src/main/java/one/mixin/android/ui/wallet/adapter/SelectableWeb3TokenAdapter.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/adapter/SelectableUserAdapter.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/adapter/SelectableTokenAdapter.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/adapter/SelectableCoinAdapter.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/wallet/adapter/SelectableAddressAdapter.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/url/UrlInterpreterActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/transfer/TransferInserter.kt	Remove redundant numeric conversion
app/src/main/java/one/mixin/android/ui/transfer/TransferClient.kt	Fix annotation target for injected constructor param
app/src/main/java/one/mixin/android/ui/transfer/TransferActivity.kt	Suppress override/deprecation warnings + simplify intent handling
app/src/main/java/one/mixin/android/ui/tip/wc/WalletConnectBottomSheetDialogFragment.kt	Remove redundant null-check (chain id is non-null)
app/src/main/java/one/mixin/android/ui/tip/wc/WalletConnectActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/tip/wc/sessionproposal/WCPinBoard.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/tip/TipActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/sticker/StickerManagementFragment.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/sticker/StickerAddFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/setting/ui/page/MixinMemberUpgradePage.kt	Remove redundant non-null assertions
app/src/main/java/one/mixin/android/ui/setting/ui/page/MixinMemberNotificationPage.kt	Fix `collectAsState` usage
app/src/main/java/one/mixin/android/ui/setting/ui/page/AppearancePage.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/setting/ui/components/MembershipPlanCard.kt	Remove redundant elvis on non-null string operation
app/src/main/java/one/mixin/android/ui/setting/SettingWallpaperFragment.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/setting/SettingStorageViewModel.kt	Remove redundant safe-call on non-null list result
app/src/main/java/one/mixin/android/ui/setting/SettingSizeFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/setting/SettingActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/setting/SafeDebugFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/setting/member/MixinMemberOrderDetailFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/setting/DatabaseDebugFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/setting/ChooseFolderContract.kt	Rename parameters to match ActivityResultContract semantics
app/src/main/java/one/mixin/android/ui/setting/AppearanceFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/search/SearchViewModel.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/search/SearchSingleFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/search/SearchMessageFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/search/SearchMessageAdapter.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/search/SearchExploreFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/search/components/RecentSearchPage.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/qr/CaptureFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/qr/CaptureActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/qr/BaseCameraxFragment.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/preview/TextPreviewActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/player/MusicService.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/player/MusicBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/player/MusicActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/player/internal/MusicMetaLoader.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/player/internal/ConversationLoader.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/PipVideoView.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/media/SharedMediaViewModel.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/media/SharedMediaActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/media/pager/transcript/TranscriptMediaPagerActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/media/pager/PlayerView.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/media/pager/PlayerControlView.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/media/pager/MediaPagerActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/media/PagedListPagerAdapter.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/logs/LogViewerScreen.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/landing/VerificationFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/landing/RestoreFragment.kt	Cursor close simplification
app/src/main/java/one/mixin/android/ui/landing/LandingFeatureItem.kt	Use-site target resource annotations (`@param:`)
app/src/main/java/one/mixin/android/ui/landing/InitializeActivity.kt	Suppress override deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/landing/components/MnemonicPhraseInput.kt	Remove redundant branches and unsafe `!!` usages
app/src/main/java/one/mixin/android/ui/landing/components/HighlightedTextWithClick.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/imageeditor/ImageEditorActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/home/web3/trade/TradePage.kt	Refactor Perpetual tab callback wiring (now must ensure non-null index)
app/src/main/java/one/mixin/android/ui/home/web3/trade/SwapTokenPage.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/home/web3/trade/perps/PerpsTpSlBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/home/web3/trade/perps/PerpsCloseBottomSheetDialogFragment.kt	Remove redundant elvis defaults for non-null fields
app/src/main/java/one/mixin/android/ui/home/web3/trade/perps/PerpsAddBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/home/web3/trade/perps/PerpetualGuidePage.kt	Use-site target resource annotations (`@param:`)
app/src/main/java/one/mixin/android/ui/home/web3/trade/CandleChart.kt	Simplify current-price fallback (safe under current guard)
app/src/main/java/one/mixin/android/ui/home/web3/BrowserPage.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/home/MainActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/home/inscription/menu/SortMenuData.kt	Use-site target resource annotations (`@param:`)
app/src/main/java/one/mixin/android/ui/home/ConversationListViewModel.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/home/ConversationListFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/home/circle/ConversationCircleEditFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/home/bot/InternalApp.kt	Use-site target resource annotations (`@param:`)
app/src/main/java/one/mixin/android/ui/group/InviteQrBottomFragment.kt	Tighten Observable generic type
app/src/main/java/one/mixin/android/ui/group/GroupActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/forward/ForwardFragment.kt	Null-safety cleanup + remove unreachable branch
app/src/main/java/one/mixin/android/ui/forward/ForwardActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/conversation/preview/PreviewDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/conversation/location/LocationActivity.kt	Refactor bounds computation (currently introduces nullable issues)
app/src/main/java/one/mixin/android/ui/conversation/link/LinkBottomSheetDialogFragment.kt	Simplify delete-address flow after prior null checks
app/src/main/java/one/mixin/android/ui/conversation/holder/AppCard.kt	Suppress noisy assertions/comparison warnings at file level
app/src/main/java/one/mixin/android/ui/conversation/GalleryAlbumFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/conversation/ConversationFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/conversation/chathistory/ChatHistoryActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/conversation/chat/ChatItemCallback.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/contacts/ContactsActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/contacts/ContactBottomSheetDialog.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/common/UtxoConsolidationBottomSheetDialogFragment.kt	Remove redundant nullable handling for trace id
app/src/main/java/one/mixin/android/ui/common/recyclerview/SafePagedListAdapter.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/common/QrBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/common/profile/ReferralBindPreviewBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/common/profile/ProfileBottomSheetDialogFragment.kt	Suppress override deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/common/OutputBottomSheetDialogFragment.kt	Simplify trace-id usage (now always non-null)
app/src/main/java/one/mixin/android/ui/common/NonMessengerUserBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/common/NoKeyWarningBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/common/message/SendMessageHelper.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/common/message/ChatRoomHelper.kt	Fix annotation target for injected constructor param
app/src/main/java/one/mixin/android/ui/common/JoinGroupBottomSheetDialogFragment.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/common/BottomSheetViewModel.kt	Remove redundant throw chaining / cleanup
app/src/main/java/one/mixin/android/ui/common/AvatarActivity.kt	Suppress override deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/call/CallActivity.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/ui/auth/AppAuthActivity.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/tip/wc/WalletConnect.kt	Simplify Uri parsing nullability
app/src/main/java/one/mixin/android/startup/EmojiAppInitializer.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/repository/Web3Repository.kt	Fix annotation target for injected constructor param
app/src/main/java/one/mixin/android/repository/TokenRepository.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/repository/SafeBoxStoreManager.kt	Fix annotation target for injected constructor param
app/src/main/java/one/mixin/android/repository/ConversationRepository.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/pay/Lighting.kt	Tighten null handling for required asset fields
app/src/main/java/one/mixin/android/net/Diagnosis.kt	Change OkHttp body usage (now requires proper closing)
app/src/main/java/one/mixin/android/media/OpusAudioRecorder.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/job/TranscriptAttachmentDownloadJob.kt	Simplify body handling (now risks null-body crash)
app/src/main/java/one/mixin/android/job/SendService.kt	Suppress override/deprecation warnings at file level
app/src/main/java/one/mixin/android/job/SendMessageJob.kt	Remove unnecessary `!!` on session key public key
app/src/main/java/one/mixin/android/job/RefreshAddressJob.kt	Remove redundant null-check on non-null response
app/src/main/java/one/mixin/android/job/ConvertVideoJob.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/job/AttachmentDownloadJob.kt	Simplify body handling (now risks null-body crash)
app/src/main/java/one/mixin/android/fts/FtsDataSource.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/extension/ViewExtension.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/extension/TextViewExtension.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/extension/TextExtension.kt	Make regex group access null-safe
app/src/main/java/one/mixin/android/extension/LogExtension.kt	Remove unnecessary `inline`
app/src/main/java/one/mixin/android/extension/ImageViewExtension.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/extension/FileExtension.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/extension/Dimesions.kt	Remove redundant float conversion
app/src/main/java/one/mixin/android/extension/ContextExtension.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/db/web3/Web3WalletDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + alias subqueries
app/src/main/java/one/mixin/android/db/web3/vo/Web3TransactionItem.kt	Fix Room converter annotation target (`@field:`)
app/src/main/java/one/mixin/android/db/web3/vo/Web3Transaction.kt	Adjust Room converter annotation target (currently `@param:`)
app/src/main/java/one/mixin/android/db/web3/vo/WalletItem.kt	Ensure ignored fields are also ignored by Parcelize
app/src/main/java/one/mixin/android/db/UserDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + normalize warning suppression
app/src/main/java/one/mixin/android/db/TranscriptMessageDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + normalize warning suppression
app/src/main/java/one/mixin/android/db/TopAssetDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + normalize warning suppression
app/src/main/java/one/mixin/android/db/TokenDao.kt	Add `@RewriteQueriesToDropUnusedColumns`
app/src/main/java/one/mixin/android/db/SafeSnapshotDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + minor formatting
app/src/main/java/one/mixin/android/db/provider/DataProvider.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/db/PerpsDatabase.kt	Make destructive migration behavior explicit
app/src/main/java/one/mixin/android/db/pending/PendingMessageDao.kt	Normalize Room warning suppression constant
app/src/main/java/one/mixin/android/db/ParticipantSessionDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + normalize warning suppression
app/src/main/java/one/mixin/android/db/OutputDao.kt	Add `@RewriteQueriesToDropUnusedColumns`
app/src/main/java/one/mixin/android/db/MixinDatabase.kt	Suppress deprecation warnings at file level + add suppression annotation
app/src/main/java/one/mixin/android/db/MessageMentionDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + normalize warning suppression
app/src/main/java/one/mixin/android/db/MessageDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + normalize warning suppression
app/src/main/java/one/mixin/android/db/MarketDao.kt	Add `@RewriteQueriesToDropUnusedColumns`
app/src/main/java/one/mixin/android/db/MarketCoinDao.kt	Add `@RewriteQueriesToDropUnusedColumns`
app/src/main/java/one/mixin/android/db/datasource/MixinLimitOffsetDataSource.kt	Suppress deprecation warnings at file level
app/src/main/java/one/mixin/android/db/ConversationDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + normalize warning suppression
app/src/main/java/one/mixin/android/db/CircleDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + normalize warning suppression
app/src/main/java/one/mixin/android/db/AssetDao.kt	Normalize Room warning suppression constant
app/src/main/java/one/mixin/android/db/AppDao.kt	Add `@RewriteQueriesToDropUnusedColumns` + normalize warning suppression
app/src/main/java/one/mixin/android/crypto/storage/MixinIdentityKeyStore.kt	Remove unreachable else branch
app/src/main/java/one/mixin/android/crypto/db/SignalDatabase.kt	Parameter rename for clarity (`db`)
app/src/main/java/one/mixin/android/crypto/CryptoWalletHelper.kt	Suppress deprecation warnings + add local suppression
app/src/main/java/one/mixin/android/crypto/CryptoUtil.kt	Add file/function suppression for deprecated API usage
app/src/main/java/one/mixin/android/compose/theme/Theme.kt	Fix annotation target + remove stray formatting
app/src/main/java/one/mixin/android/compose/TextHighlight.kt	Migrate link handling to `LinkAnnotation` approach
app/src/main/java/one/mixin/android/compose/InputAmountScreen.kt	Update Hilt Compose import path
app/src/main/java/one/mixin/android/api/response/TransactionResponse.kt	Remove redundant non-null assertion

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

                    data?.forEachIndexed { index, item ->
                        south =
                            if (south == null) {
                                item.location.lat
                            } else {
-                                min(south!!, item.location.lat)
+                                min(south, item.location.lat)
                            }
                        west =
                            if (west == null) {
                                item.location.lng
                            } else {
-                                min(west!!, item.location.lng)
+                                min(west, item.location.lng)
                            }
                        north =
                            if (north == null) {
                                item.location.lat
                            } else {
-                                max(north!!, item.location.lat)
+                                max(north, item.location.lat)
                            }
                        east =
                            if (east == null) {
                                item.location.lng
                            } else {
-                                max(east!!, item.location.lng)
+                                max(east, item.location.lng)
                            }


                        mixinMapView.addMarker(index, item)

-                        if (south != null && west != null && north != null && east != null) {
-                            val bound = MixinLatLngBounds(MixinLatLng(south!!, west!!), MixinLatLng(north!!, east!!))
-                            mixinMapView.moveBounds(bound)
-                        }
+                        val bound = MixinLatLngBounds(MixinLatLng(south, west), MixinLatLng(north, east))
+                        mixinMapView.moveBounds(bound)


                        snapshotItems = list.map {
                            if (!it.withdrawal?.receiver.isNullOrBlank()) {
-                                val receiver = it.withdrawal!!.receiver
+                                val receiver = it.withdrawal.receiver
                                val index: Int = receiver.indexOf(":")
                                if (index == -1) {


            SafeSnapshotType.withdrawal -> {
-                withdrawal?.receiver.isNullOrBlank() || withdrawal?.withdrawalHash.isNullOrBlank()
+                withdrawal?.receiver.isNullOrBlank() || withdrawal.withdrawalHash.isNullOrBlank()
            }


    var perpetualTabIndex: Int? = null
    if (walletId == null) {
        perpetualTabIndex = tabs.size
        tabs += TabItem(title = stringResource(R.string.Perpetual)) {
            PerpetualContent(
-                onShowTradingGuide = { onShowTradingGuide(perpetualTabIndex ?: 0) },
+                onShowTradingGuide = { onShowTradingGuide(perpetualTabIndex) },
                onShowMarketList = onShowMarketList,
                onShowAllMarkets = onShowAllMarkets,


            destination.delete()
            return true
-        } else if (response.isSuccessful && !isCancelled && response.body != null) {
+        } else if (response.isSuccessful && !isCancelled) {
            val sink = destination.sink().buffer()
-            sink.writeAll(response.body!!.source())
+            sink.writeAll(response.body.source())
            sink.close()


        val response = requireNotNull(call).execute()
        if (response.code == 404) {
            destination.delete()
            return true
-        } else if (response.isSuccessful && !isCancelled && response.body != null) {
+        } else if (response.isSuccessful && !isCancelled) {
            val sink = destination.sink().buffer()
-            sink.writeAll(response.body!!.source())
+            sink.writeAll(response.body.source())
            sink.close()


+    @param:TypeConverters(AssetChangeListConverter::class)
    @ColumnInfo(name = "senders")
    @SerializedName("senders")
    val senders: List<AssetChange>?,

-    @TypeConverters(AssetChangeListConverter::class)
+    @param:TypeConverters(AssetChangeListConverter::class)
    @ColumnInfo(name = "receivers")
    @SerializedName("receivers")
    val receivers: List<AssetChange>?,

-    @TypeConverters(AssetChangeListConverter::class)
+    @param:TypeConverters(AssetChangeListConverter::class)
    @ColumnInfo(name = "approvals")
    @SerializedName("approvals")
    val approvals: List<AssetChange>? = null,


                val request = Request.Builder().url(url).build()
                val response = okHttpClient.newCall(request).execute()
                if (response.isSuccessful) {
-                    response.body?.string()?.stripInvisibleCharacters()
+                    response.body.string().stripInvisibleCharacters()
                } else {


@@ -149,7 +146,7 @@ private fun getExportIp(
        Timber.i("Get export ip from $EXPORT_IP_PRIMARY meet ${e.localizedMessage}")
        try {
            ipRequest = Request.Builder().url(EXPORT_IP_SECONDARY).build()
-            val exportIp = client.newCall(ipRequest).execute().body?.string()
+            val exportIp = client.newCall(ipRequest).execute().body.string()
            result.append("${context.getString(R.string.export_ip)}: $exportIp")


SeniorZhai added 19 commits May 25, 2026 15:06

fix(db): resolve Room warnings and SQL syntax errors

58d9321

- Replace deprecated RoomWarnings.CURSOR_MISMATCH with QUERY_MISMATCH - Add @RewriteQueriesToDropUnusedColumns to DAO interfaces - Fix SQL syntax error in Web3WalletDao subquery

fix(ui): replace deprecated Compose components and update Hilt imports

8f490c6

- Replace deprecated ClickableText with Text and LinkAnnotation - Update hiltViewModel import to non-deprecated package - Add @param: target to @DrawableRes in AppDrawables

fix(crypto): address deprecation and naming warnings in crypto module

aedb3cf

- Suppress DEPRECATION warnings for EncryptedSharedPreferences - Fix migration parameter naming in SignalDatabase - Remove redundant else branch in MixinIdentityKeyStore

fix(compose): add missing Column import in TextHighlight preview

a795a67

chore: remove unnecessary non-null assertions and safe calls

7cdc472

chore: clean up redundant null assertions, conversions and elvis ops

048290d

chore(crypto): suppress EncryptedSharedPreferences/MasterKey deprecation

c82bd9a

chore: suppress deprecated PagedList warnings across affected files

822d1dd

chore: suppress deprecation warnings across modules

615238b

chore: suppress deprecated override warnings

186cea2

chore: add explicit annotation use-site targets

1b3f99f

chore: simplify always-true/false conditions

9ae3867

chore: clean up assorted warnings and suppress misleading ones

16b4c1f

fix(forward): correct duplicate ShareCategory branch and clean redund…

b70223f

…ant null checks

chore: remove redundant null checks, safe calls and when else branches

cc1c36c

chore: remove redundant null safety and exhaustive when else

4de2adc

chore: remove redundant conversions and unnecessary null safety

e534e7e

fix(warnings): align override parameter names

7ded36b

SeniorZhai requested a review from Copilot May 25, 2026 07:15

SeniorZhai added the testing Now testing, but you can review label May 25, 2026

Copilot started reviewing on behalf of SeniorZhai May 25, 2026 07:15 View session

chore(member): remove unused notification sheet

c797eb1

Copilot AI reviewed May 25, 2026

View reviewed changes

crossle and others added 2 commits May 25, 2026 11:28

Merge branch 'master' into fix/compilation-warnings

34da0c0

chore(warnings): clean up remaining compilation warnings

497c643

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/compilation warnings#6405

Fix/compilation warnings#6405
SeniorZhai wants to merge 22 commits into
masterfrom
fix/compilation-warnings

SeniorZhai commented May 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

SeniorZhai commented May 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants