Skip to content

Improve Font Icon Set name assignment #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simon-ign merged 38 commits into from
May 19, 2026
Merged

Improve Font Icon Set name assignment #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
70d030b
Create FontIconSetDefinition
keveleigh Nov 11, 2025
8a2156c
Add MRTK default asset
keveleigh Nov 11, 2025
9bf3247
Fix race condition where the deserialized value was being read before…
keveleigh Nov 11, 2025
de30071
Update field naming and general formatting
keveleigh Nov 11, 2025
c04bfda
Fix issue where the wrong color param was being set
keveleigh Nov 11, 2025
d1aaf3f
Disable buttons if the icon has already been added
keveleigh Nov 11, 2025
29a2ba5
Update to use Foldout instead of BeginFoldoutHeaderGroup
keveleigh Nov 11, 2025
6e4569e
Update FontIconSetInspector.cs
keveleigh Nov 11, 2025
08a09c8
Update selected icons display for improved flow and usage
keveleigh Nov 11, 2025
c0f3a6f
Add FontIconSetDefinition to FontIconSet
keveleigh Nov 11, 2025
6f39006
Fix asset not being marked dirty when changed
keveleigh Nov 11, 2025
d5cd944
Simplify CRUD method implementations
keveleigh Nov 11, 2025
3ddef7c
Sort the added symbols by unicode value
keveleigh Nov 11, 2025
4cf3e97
Update FontIconSetDefinition.cs
keveleigh Nov 11, 2025
6119d99
Create dropdown for accessing icon set definition names
keveleigh Nov 11, 2025
1b89dd6
Update Selawik-Semibold-MRTKIcons.asset
keveleigh Nov 11, 2025
7e65036
Add migration path for FontIconSelector
keveleigh Nov 12, 2025
5339aec
Update FontIconSelectorInspector.cs
keveleigh Nov 12, 2025
a154af1
Add FontIconSelectorMigrationUtility
keveleigh May 15, 2026
6e33fd7
Add FontIconSelectorTests
keveleigh May 15, 2026
335a5be
Improve robustness
keveleigh Dec 5, 2025
25e6b8b
Improvements
keveleigh May 15, 2026
c7d2fea
Sort names
keveleigh May 15, 2026
90b8f9c
Map MRTK_FluentIconSet
keveleigh May 15, 2026
478b1da
Add more icon names
keveleigh May 15, 2026
3da604a
More names!
keveleigh May 15, 2026
3dc8751
More names
keveleigh May 15, 2026
45a134e
Sort the icons
keveleigh May 15, 2026
75f91a3
Robustness
keveleigh May 16, 2026
9d064ca
Improve migration
keveleigh May 18, 2026
ee8c0b7
Updates
keveleigh May 19, 2026
3d683a4
Robustness
keveleigh May 19, 2026
3eed573
Update changelog and package version
keveleigh May 19, 2026
9b435dc
Update CHANGELOG.md
keveleigh May 19, 2026
864791c
Update FontIconSetInspector.cs
keveleigh May 19, 2026
2b1f4a1
Add change deferrals
keveleigh May 19, 2026
2b52d81
Update Action Button.prefab
keveleigh May 19, 2026
cde040f
Update SampleSceneHandMenu.prefab
keveleigh May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions UnityProjects/MRTKDevTemplate/Assets/Prefabs/SampleSceneHelper/SampleSceneHandMenu.prefab
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1538,7 +1538,7 @@ PrefabInstance:
objectReference: {fileID: 0}
- target: {fileID: 7245587814888172855, guid: c6b351a67ceb69140b199996bbbea156, type: 3}
propertyPath: currentIconName
value: Icon 59
value: Chevron Left
objectReference: {fileID: 0}
- target: {fileID: 7594107385585372191, guid: c6b351a67ceb69140b199996bbbea156, type: 3}
propertyPath: m_IsActive
Expand Down Expand Up @@ -2147,7 +2147,7 @@ PrefabInstance:
objectReference: {fileID: 0}
- target: {fileID: 7245587814888172855, guid: c6b351a67ceb69140b199996bbbea156, type: 3}
propertyPath: currentIconName
value: Icon 60
value: Chevron Right
objectReference: {fileID: 0}
- target: {fileID: 7594107385585372191, guid: c6b351a67ceb69140b199996bbbea156, type: 3}
propertyPath: m_IsActive
Expand Down
6 changes: 6 additions & 0 deletions org.mixedrealitytoolkit.standardassets/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## Unreleased

### Changed

* Updated icon names in MRTK_FluentIconSet.asset and Selawik-Semibold-MRTKIcons.asset to be more descriptive. [PR #1077](https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/1077)

## [3.2.1] - 2025-11-12

### Fixed
Expand Down
Loading