Skip to content

Conversation

@anh-duc-le
Copy link

  • Upgraded the NET Framework from 4.0 => 4.5
  • Added README.md and comments for the following:

In order to run the ConsoleTests you'll first need the following:

  • You need at least 5 changesets in your repository.
  • You need at least 5 issues in your repository.
  • You need at least 1 SSH Key on your user
  • RequestExecutor.cs

    • Added ExecuteRequestWithLogging()
  • Sharpbucket.cs

    • Added Serilog ILogger overload to methods
  • EndPoint.cs

    • Added Serilog ILogger overload to methods
  • repositoriesEndPoint

    • Added Serilog ILogger overload to methods
  • Repository Resource

    • Added Serilog ILogger overload to methods.
    • Added PutRepository …
    • Added PostBranch
    • Added ListBranch
  • TeamEndPoin : Added PostProject/ ListProjects / GetProject …

  • UserEndPoint: Added GetEmails

POCOS :

  • Added :
    • Email
    • Group
    • LinkConfigurations
    • Member
    • Project
    • ProjectPostParams
  • Modified :
    • Branch
    • Branchrestriction
    • Repository
    • User

Anh-Duc Le added 12 commits April 25, 2018 14:49
 DeleteRepository returns HttpStatusCode instead of Repository.
* Added PostBranch
* Added ListBranch
UserEndPoint: Added GetEmails

POCOS :

+ Added Email/ Group/ LinkConfigurations/ Member/ Project/ ProjectPostParams
+ Modified Branch / Branchrestriction / Repository / User
    public string slug { get; set; }
@mnivet
Copy link
Collaborator

mnivet commented Nov 29, 2018

It seems that you have implemented new endpoints and resources for the V2 API which is appreciated
but taking a dependency on a logger like serilog is not wanted for a library like SharpBucket

Can you clean up your pull request to just the support of the new endpoints and resources ?

@Tanzy
Copy link
Contributor

Tanzy commented Nov 29, 2018

Take a look at https://github.com/damianh/LibLog you are not depending on one particular logging framework then

@mnivet
Copy link
Collaborator

mnivet commented Nov 30, 2018

I didn't know liblog but it seems effectively a interesting solution to not expose dependency to a specific logging framework

but it's not done with that lib yet in that pull request, and I would prefer to validate separate pull requests, one for adding a log support, and one for adding support of new endpoints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants