fix(NT-R / NT-H): ResetState needs to use actual values, not zeros #4088
+34
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements to SyncVar hook handling exposed this latent issue where clients were sending update to server with spawn values unnecessarily. Initializing `last` and related values from Awake -> Configure -> ResetState ensures both sides are in sync from spawn without needing to send erroneous update messages.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to SyncVar hook handling exposed this latent issue where clients were sending update to server with spawn values unnecessarily, causing host client to apply the update as a delta and sending the object to double its actual pos.
Initializing
lastand related values from Awake/OnEnable -> Configure -> ResetState ensures both sides are in sync from spawn without needing to send erroneous update messages.