GEOPY-2883: Remove dependency on Tx frequency for airborne FEM survey#144
Merged
Conversation
github-actions
Bot
changed the title
There was a problem hiding this comment.
Pull request overview
This PR removes the dependency on the transmitter channel value when tracking GeoH5 entity_type reuse during iterative saves, instead using the channel’s positional index. This aligns the saved-type bookkeeping with channel ordering rather than potentially unstable/duplicated channel values (e.g., frequencies in airborne FEM).
Changes:
- Key
self.data_type[component]by channel index (ii) instead of the channel value (channel) when persisting/reusingentity_typeacross iterations. - Update the corresponding
find_typelookup to use the index-keyed stored type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benk-mira
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2883 - Remove dependency on Tx frequency for airborne FEM survey