Skip to content

GEOPY-2775: DCIP 2D crash on line ID selection#366

Merged
benk-mira merged 7 commits intodevelopfrom
GEOPY-2775
Mar 27, 2026
Merged

GEOPY-2775: DCIP 2D crash on line ID selection#366
benk-mira merged 7 commits intodevelopfrom
GEOPY-2775

Conversation

@domfournier
Copy link
Copy Markdown
Collaborator

@domfournier domfournier commented Mar 24, 2026

GEOPY-2775 - DCIP 2D crash on line ID selection

Copilot AI review requested due to automatic review settings March 24, 2026 22:44
@github-actions github-actions bot changed the title GEOPY-2775 GEOPY-2775: DCIP 2D crash on line ID selection Mar 24, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts 2D mesh construction and nested-simulation active-cell selection to be more robust in edge cases encountered in GEOPY-2775.

Changes:

  • Round min/max extents passed into mesh_builder_xyz during drape-model mesh creation to avoid floor/int rounding edge cases.
  • Update DCIP-2D nested simulation mapping to derive active mesh parts from source/electrode locations rather than assuming line IDs match mesh part numbering.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
simpeg_drivers/utils/utils.py Computes floored/ceiled distance/elevation limits before building the tensor mesh for drape-model generation.
simpeg_drivers/utils/nested.py Determines active mesh parts for DCIP-2D via cell lookup on cell_centers_x and mesh.parts, removing the sequential-ID assumption.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.83%. Comparing base (faf805d) to head (14c1421).
⚠️ Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #366      +/-   ##
===========================================
- Coverage    89.85%   89.83%   -0.02%     
===========================================
  Files          125      125              
  Lines         6435     6437       +2     
  Branches       794      794              
===========================================
+ Hits          5782     5783       +1     
  Misses         449      449              
- Partials       204      205       +1     
Files with missing lines Coverage Δ
simpeg_drivers/utils/nested.py 95.43% <100.00%> (+0.02%) ⬆️
simpeg_drivers/utils/utils.py 70.58% <100.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benk-mira benk-mira merged commit b1ad7f4 into develop Mar 27, 2026
19 checks passed
@benk-mira benk-mira deleted the GEOPY-2775 branch March 27, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants