GEOPY-2456: Solve warning issues raised by RTD#906
Open
domfournier wants to merge 14 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/GA_4.8 #906 +/- ##
===============================================
Coverage 91.16% 91.16%
===============================================
Files 114 114
Lines 10595 10597 +2
Branches 1964 1964
===============================================
+ Hits 9659 9661 +2
Misses 493 493
Partials 443 443
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets ReadTheDocs (RTD) build warnings by improving Pydantic autodoc compatibility, updating documentation cross-references, and renaming a survey “type” discriminator property to avoid conflicts.
Changes:
- Add explicit
__pydantic_extra__typing to UI JSON Pydantic models to silence autodoc issues. - Rename
Survey.type→Survey.type_nameacross survey implementations and dependent code paths. - Update multiple user-guide notebooks to use
{py:...}Sphinx roles instead of hard-coded RST anchor links.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ui_json/uijson_test.py | Adds Any import for typing/autodoc-related needs in tests. |
| tests/ui_json/forms_test.py | Adjusts imports to align with updated typing/autodoc needs. |
| geoh5py/ui_json/ui_json.py | Adds __pydantic_extra__ annotation for Pydantic autodoc compatibility. |
| geoh5py/ui_json/forms.py | Adds __pydantic_extra__ annotation for Pydantic autodoc compatibility. |
| geoh5py/objects/surveys/electromagnetics/tipper.py | Renames type property to type_name. |
| geoh5py/objects/surveys/electromagnetics/magnetotellurics.py | Renames type property to type_name. |
| geoh5py/objects/surveys/electromagnetics/ground_tem.py | Renames type property to type_name across TEM survey elements. |
| geoh5py/objects/surveys/electromagnetics/ground_fem.py | Renames type property to type_name across FEM survey elements. |
| geoh5py/objects/surveys/electromagnetics/base.py | Updates internal logic to use type_name instead of type. |
| geoh5py/objects/surveys/electromagnetics/airborne_tem.py | Renames type property to type_name. |
| geoh5py/objects/surveys/electromagnetics/airborne_fem.py | Renames type property to type_name. |
| geoh5py/objects/surveys/electromagnetics/airborne_app_con.py | Renames type property to type_name. |
| geoh5py/objects/surveys/direct_current.py | Renames type property to type_name for DC survey elements. |
| geoh5py/objects/surveys/base.py | Changes abstract API surface from type to type_name. |
| geoh5py/groups/base.py | Updates copy logic to use type_name for survey children filtering. |
| docs/content/user_guide/tipper.ipynb | Replaces RST anchor links with {py:...} Sphinx roles; updates notebook metadata. |
| docs/content/user_guide/objects.ipynb | Updates a method reference to {py:func} and notebook metadata. |
| docs/content/user_guide/magnetotelluric.ipynb | Replaces RST anchor links with {py:...} Sphinx roles; updates notebook metadata. |
| docs/content/user_guide/direct_current.ipynb | Replaces RST anchor links with {py:...} Sphinx roles; minor wording/metadata updates. |
| docs/content/user_guide/data.ipynb | Adds a section label and updates links/references to Sphinx roles; updates notebook metadata. |
| docs/content/user_guide/airborne_tem.ipynb | Replaces RST anchor links with {py:...} Sphinx roles; updates kernelspec/metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2456 - Solve warning issues raised by RTD