GEOPY-2744: Migrate core utilities to geoapps-utils and geoh5py#862
Merged
domfournier merged 3 commits intodevelopfrom Mar 25, 2026
Merged
GEOPY-2744: Migrate core utilities to geoapps-utils and geoh5py#862domfournier merged 3 commits intodevelopfrom
domfournier merged 3 commits intodevelopfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #862 +/- ##
========================================
Coverage 91.18% 91.19%
========================================
Files 115 115
Lines 10298 10332 +34
Branches 1901 1911 +10
========================================
+ Hits 9390 9422 +32
- Misses 485 486 +1
- Partials 423 424 +1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR moves fill and to_ui_json_group functionality into geoh5py.ui_json.BaseUIJson, and adds unit tests to validate the new behaviors.
Changes:
- Added
BaseUIJson.fill()for updating form values (in-place or via copy). - Added
BaseUIJson.to_ui_json_group()for persisting a UI JSON configuration into aUIJsonGroupin a workspace. - Expanded
tests/ui_json/uijson_test.pywith coverage for both new methods.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
geoh5py/ui_json/ui_json.py |
Adds fill() and to_ui_json_group(), adjusts config/validators, and tweaks read() behavior for empty-string handling. |
tests/ui_json/uijson_test.py |
Introduces new tests validating fill() semantics and to_ui_json_group() group creation/options. |
Comments suppressed due to low confidence (1)
geoh5py/ui_json/ui_json.py:119
- The
valid_geoh5_extensionvalidator acceptsNone(it checkspath is not None), but its signature ispath: Path. Update the parameter type toPath | Noneto match the model field and avoid type-checking issues.
@field_validator("geoh5", mode="after")
@classmethod
def valid_geoh5_extension(cls, path: Path):
if path is not None and path.suffix != ".geoh5":
raise ValueError(
f"Workspace path: {path} must have a '.geoh5' file extension."
)
return path
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
domfournier
reviewed
Mar 25, 2026
+ copilote comments
domfournier
previously approved these changes
Mar 25, 2026
Remove model_field usage to avoid deprecation error
domfournier
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2744 - Migrate core utilities to geoapps-utils and geoh5py
transfer fill and to_uijson_group functions from geopy-aq to uijson