Skip to content

GEOPY-2744: Migrate core utilities to geoapps-utils and geoh5py#189

Merged
domfournier merged 4 commits intodevelopfrom
GEOPY-2744
Mar 25, 2026
Merged

GEOPY-2744: Migrate core utilities to geoapps-utils and geoh5py#189
domfournier merged 4 commits intodevelopfrom
GEOPY-2744

Conversation

@MatthieuCMira
Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira commented Mar 24, 2026

GEOPY-2744 - Migrate core utilities to geoapps-utils and geoh5py
move functions from geopy-qa to geoapps-utils

@github-actions github-actions bot changed the title Geopy 2744 GEOPY-2744: Migrate core utilities to geoapps-utils and geoh5py Mar 24, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a small driver utility in geoapps_utils (migrating functionality previously living in geopy-qa) to retrieve a driver’s default ui.json template content, along with a unit test covering the new behavior.

Changes:

  • Import BaseUIJson where needed and introduce Driver.get_empty_ui_json() to read the default ui.json template.
  • Add unit test coverage validating the new method’s behavior for drivers with/without a default ui.json.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
geoapps_utils/base.py Adds get_empty_ui_json() and imports BaseUIJson to support reading the default/template ui.json.
tests/driver_test.py Adds a new test validating get_empty_ui_json() behavior and updates imports accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.41%. Comparing base (f7b28e0) to head (3e01e2b).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #189      +/-   ##
===========================================
+ Coverage    86.05%   86.41%   +0.35%     
===========================================
  Files           19       19              
  Lines         1119     1126       +7     
  Branches       150      151       +1     
===========================================
+ Hits           963      973      +10     
+ Misses         116      114       -2     
+ Partials        40       39       -1     
Files with missing lines Coverage Δ
geoapps_utils/base.py 91.71% <100.00%> (+0.33%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier merged commit eb04741 into develop Mar 25, 2026
20 checks passed
@domfournier domfournier deleted the GEOPY-2744 branch March 25, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants