GEOPY-2744: Migrate core utilities to geoapps-utils and geoh5py#189
Merged
domfournier merged 4 commits intodevelopfrom Mar 25, 2026
Merged
GEOPY-2744: Migrate core utilities to geoapps-utils and geoh5py#189domfournier merged 4 commits intodevelopfrom
domfournier merged 4 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a small driver utility in geoapps_utils (migrating functionality previously living in geopy-qa) to retrieve a driver’s default ui.json template content, along with a unit test covering the new behavior.
Changes:
- Import
BaseUIJsonwhere needed and introduceDriver.get_empty_ui_json()to read the default ui.json template. - Add unit test coverage validating the new method’s behavior for drivers with/without a default ui.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
geoapps_utils/base.py |
Adds get_empty_ui_json() and imports BaseUIJson to support reading the default/template ui.json. |
tests/driver_test.py |
Adds a new test validating get_empty_ui_json() behavior and updates imports accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #189 +/- ##
===========================================
+ Coverage 86.05% 86.41% +0.35%
===========================================
Files 19 19
Lines 1119 1126 +7
Branches 150 151 +1
===========================================
+ Hits 963 973 +10
+ Misses 116 114 -2
+ Partials 40 39 -1
🚀 New features to boost your workflow:
|
domfournier
reviewed
Mar 24, 2026
domfournier
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2744 - Migrate core utilities to geoapps-utils and geoh5py
move functions from geopy-qa to geoapps-utils