Skip to content

GEOPY-2523: another fix in the actual get_logger function #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatthieuCMira merged 4 commits into from
Oct 14, 2025
Merged

GEOPY-2523: another fix in the actual get_logger function #165

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
689bee1
minimal change in the logger to avoid double printing
MatthieuCMira Oct 14, 2025
b7a84a7
set logging level default to info.
MatthieuCMira Oct 14, 2025
4905d3e
remove positional argument error
MatthieuCMira Oct 14, 2025
0101808
Merge branch 'develop' into GEOPY-2523
MatthieuCMira Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions geoapps_utils/utils/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@

def get_logger(
name: str | None = None,
*,
timestamp: bool = False,
level_name: bool = True,
propagate: bool = True,
add_name: bool = True,
level: int = logging.INFO,
) -> logging.Logger:
"""
Get a logger with a timestamped stream and specified log level.
Expand All @@ -27,15 +29,19 @@ def get_logger(
:param level_name: Whether to include the log level name in the log format.
:param propagate: Whether to propagate log messages to the parent logger.
:param add_name: Whether to include the logger name in the log format.
:param level: Logging level (e.g., logging.DEBUG, logging.INFO).

:return: Configured logger instance.
"""
log = logging.getLogger(name)

log.propagate = propagate
stream_handler: logging.Handler = logging.StreamHandler()
if log.handlers:
stream_handler = log.handlers[0]
else:
stream_handler = logging.StreamHandler()
if not propagate:
log.handlers.clear()
else:
stream_handler = log.handlers[0]

# Set the format for the logger
formatting = ""
Expand All @@ -51,6 +57,7 @@ def get_logger(
formatter = logging.Formatter(formatting + "%(message)s")
stream_handler.setFormatter(formatter)
log.addHandler(stream_handler)
log.propagate = propagate

log.setLevel(level)

return log