Skip to content

GEOPY-2466: Parallelize the Sweeps#164

Merged
domfournier merged 2 commits intodevelopfrom
GEOPY-2466
Sep 29, 2025
Merged

GEOPY-2466: Parallelize the Sweeps#164
domfournier merged 2 commits intodevelopfrom
GEOPY-2466

Conversation

@domfournier
Copy link
Copy Markdown
Contributor

@domfournier domfournier commented Sep 25, 2025

GEOPY-2466 - Parallelize the Sweeps

@github-actions github-actions bot changed the title GEOPY-2466 GEOPY-2466: Parallelize the Sweeps Sep 25, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.10%. Comparing base (af0d42f) to head (4465f03).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
geoapps_utils/run.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #164      +/-   ##
===========================================
+ Coverage    86.08%   86.10%   +0.02%     
===========================================
  Files           19       19              
  Lines         1085     1087       +2     
  Branches       146      146              
===========================================
+ Hits           934      936       +2     
  Misses         112      112              
  Partials        39       39              
Files with missing lines Coverage Δ
geoapps_utils/run.py 92.38% <90.90%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me.

Good idea to not open the workspace when just copying it!

ifile.copy_relatives(new_workspace)
temp_json = ifile.ui_json.copy()
temp_json["geoh5"] = workspace_path
temp_json["geoh5"] = new_workspace
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why new_workspace?
We don't want to store the path where the workspace is created?
Maybe it ends up doing the same thing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By providing the current active workspace, we can skip re-opening the file again during the InputFile instantiation.

@domfournier domfournier merged commit 1398046 into develop Sep 29, 2025
15 checks passed
@domfournier domfournier deleted the GEOPY-2466 branch September 29, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants