Skip to content

Bor#7

Open
MinyazevR wants to merge 10 commits into
mainfrom
Bor
Open

Bor#7
MinyazevR wants to merge 10 commits into
mainfrom
Bor

Conversation

@MinyazevR
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

@yurii-litvinov yurii-litvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо немного доисправлять

Comment thread Homework2/Bor/Bor/Bor.cs Outdated
/// <summary>
/// A class representing the bor data structure
/// </summary>
public class Bor
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Он не Bor, он Trie

Comment thread Homework2/Bor/Bor/Bor.cs Outdated
public class Bor
{
/// <summary>
/// // A class representing the bor data structure
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не совсем правда, и комментарий в неправильном формате, достаточно ///

Comment thread Homework2/Bor/Bor/Bor.cs Outdated
return node.IsTerminal ? 1 + node.Nodes.Count : node.Nodes.Count;
}

// Function for clearing dictionaries
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Внезапно комментарий не в стандартном формате

Comment thread Homework2/Bor/Bor/Bor.cs Outdated

int index = 0;
Node node = root;
Node? anotherNode = null;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я бы назвал его parent или как-то так, потому что вообще непонятна его роль сейчас

Comment thread Homework2/Bor/BorTest/BorTest.cs Outdated

public class BorTest
{
Bor bor = new();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Bor bor = new();
private Bor bor = new();

MinyazevR added 8 commits June 2, 2022 00:31
This reverts commit 480d6ba.
This reverts commit 480d6ba.

# Conflicts:
#	.github/workflows/dotnet.txt
This reverts commit b7fc6d2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants